fpdfsdk/fpdfdoc_unittest.cpp - Issue 2509123002: Make CPDF_Object subclass constructors intern strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdfdoc_unittest.cpp

Issue 2509123002: Make CPDF_Object subclass constructors intern strings (Closed)

Patch Set: Nits Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdfdoc_unittest.cpp

diff --git a/fpdfsdk/fpdfdoc_unittest.cpp b/fpdfsdk/fpdfdoc_unittest.cpp

index 50837d52e3b03fad389a53f0e9901edb458720c1..d049b4e7576fbad836cd03a6cfa3d99a992a04fa 100644

--- a/fpdfsdk/fpdfdoc_unittest.cpp

+++ b/fpdfsdk/fpdfdoc_unittest.cpp

@@ -129,7 +129,7 @@ TEST_F(PDFDocTest, FindBookmark) {

bookmarks[2].obj->SetFor(

"Prev", new CPDF_Reference(m_pIndirectObjs, bookmarks[1].num));

- bookmarks[0].obj->SetFor("Type", new CPDF_Name("Outlines"));

+ bookmarks[0].obj->SetFor("Type", new CPDF_Name(nullptr, "Outlines"));

bookmarks[0].obj->SetFor("Count", new CPDF_Number(2));

bookmarks[0].obj->SetFor(

"First", new CPDF_Reference(m_pIndirectObjs, bookmarks[1].num));

@@ -172,7 +172,7 @@ TEST_F(PDFDocTest, FindBookmark) {

bookmarks[2].obj->SetFor(

"First", new CPDF_Reference(m_pIndirectObjs, bookmarks[1].num));

- bookmarks[0].obj->SetFor("Type", new CPDF_Name("Outlines"));

+ bookmarks[0].obj->SetFor("Type", new CPDF_Name(nullptr, "Outlines"));

bookmarks[0].obj->SetFor("Count", new CPDF_Number(2));

bookmarks[0].obj->SetFor(

"First", new CPDF_Reference(m_pIndirectObjs, bookmarks[1].num));

@@ -213,7 +213,7 @@ TEST_F(PDFDocTest, FindBookmark) {

bookmarks[3].obj->SetFor(

"Next", new CPDF_Reference(m_pIndirectObjs, bookmarks[1].num));

- bookmarks[0].obj->SetFor("Type", new CPDF_Name("Outlines"));

+ bookmarks[0].obj->SetFor("Type", new CPDF_Name(nullptr, "Outlines"));

bookmarks[0].obj->SetFor("Count", new CPDF_Number(2));

bookmarks[0].obj->SetFor(

"First", new CPDF_Reference(m_pIndirectObjs, bookmarks[1].num));

« no previous file with comments | « fpdfsdk/formfiller/cba_fontmap.cpp ('k') | fpdfsdk/fpdfeditpage.cpp » ('j') | no next file with comments »