fpdfsdk/formfiller/cba_fontmap.cpp - Issue 2509123002: Make CPDF_Object subclass constructors intern strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/formfiller/cba_fontmap.cpp

Issue 2509123002: Make CPDF_Object subclass constructors intern strings (Closed)

Patch Set: Nits Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/formfiller/cba_fontmap.cpp

diff --git a/fpdfsdk/formfiller/cba_fontmap.cpp b/fpdfsdk/formfiller/cba_fontmap.cpp

index 2d962ad276b16a599080cc6e30b4d98145a65302..fd9304befc8e478237c6c71d9742f6d91389447e 100644

--- a/fpdfsdk/formfiller/cba_fontmap.cpp

+++ b/fpdfsdk/formfiller/cba_fontmap.cpp

@@ -184,8 +184,7 @@ void CBA_FontMap::AddFontToAnnotDict(CPDF_Font* pFont,

}

CPDF_Dictionary* pStreamResFontList = pStreamResList->GetDictFor("Font");

if (!pStreamResFontList) {

- pStreamResFontList = m_pDocument->NewIndirect<CPDF_Dictionary>(

- m_pDocument->GetByteStringPool());

+ pStreamResFontList = m_pDocument->NewIndirect<CPDF_Dictionary>();

pStreamResList->SetReferenceFor("Font", m_pDocument, pStreamResFontList);

}

if (!pStreamResFontList->KeyExist(sAlias)) {

« no previous file with comments | « core/fxcrt/cfx_weak_ptr.h ('k') | fpdfsdk/fpdfdoc_unittest.cpp » ('j') | no next file with comments »