Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2509013002: Allocate generic types in new-space before canonicalizing. (Closed)

Created:
4 years, 1 month ago by Florian Schneider
Modified:
4 years, 1 month ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allocate generic types in new-space before canonicalizing. A previous CL missed the second allocation site (https://github.com/dart-lang/sdk/commit/6418f8f36caf4f6af2f575c2f1a7ca828d82ee00) in Instance::GetType. Pass space used in GetType() explicitly to use old-space when invoked from the background compiler. Fixes #27663. R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/86d62d66f2933f1388bd11d76f47d372305dcfa5

Patch Set 1 #

Patch Set 2 : formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -22 lines) Patch
M runtime/lib/errors.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/lib/mirrors.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/object.cc View 1 5 chunks +8 lines, -6 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/code_generator.cc View 1 4 chunks +5 lines, -4 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/debugger_api_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/object.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Florian Schneider
4 years, 1 month ago (2016-11-16 19:20:07 UTC) #3
regis
lgtm
4 years, 1 month ago (2016-11-16 19:55:55 UTC) #4
Florian Schneider
4 years, 1 month ago (2016-11-16 20:41:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
86d62d66f2933f1388bd11d76f47d372305dcfa5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698