runtime/vm/class_finalizer.cc - Issue 2509013002: Allocate generic types in new-space before canonicalizing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/class_finalizer.cc

Issue 2509013002: Allocate generic types in new-space before canonicalizing. (Closed)

Patch Set: formatting Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/class_finalizer.cc

diff --git a/runtime/vm/class_finalizer.cc b/runtime/vm/class_finalizer.cc

index 5c11514e7cd9a39d32baf1a1a1b87eca403ef2ac..c8683eeb69f22d94bd1f14990e02c52ee4699676 100644

--- a/runtime/vm/class_finalizer.cc

+++ b/runtime/vm/class_finalizer.cc

@@ -1438,7 +1438,7 @@ void ClassFinalizer::ResolveAndFinalizeMemberTypes(const Class& cls) {

&error))) {

if (Isolate::Current()->error_on_bad_type()) {

const AbstractType& const_value_type =

- AbstractType::Handle(zone, const_value.GetType());

+ AbstractType::Handle(zone, const_value.GetType(Heap::kNew));

const String& const_value_type_name =

String::Handle(zone, const_value_type.UserVisibleName());

const String& type_name =

« no previous file with comments | « runtime/lib/object.cc ('k') | runtime/vm/code_generator.cc » ('j') | no next file with comments »