Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2508853003: [debug-wrapper] clearAllBreakPoints and several scripts functions (Closed)

Created:
4 years, 1 month ago by jgruber
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug-wrapper] clearAllBreakPoints and several scripts functions This adds clearAllBreakPoints functionality (which requires tracking set breakpoints internally), and several script-related functions that rely on runtime functions. BUG=v8:5530 Committed: https://crrev.com/2c8a4155aad5cae6fd1148d72663cfa2e68f9637 Cr-Commit-Position: refs/heads/master@{#41064}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -373 lines) Patch
A + test/debugger/debug/debug-sourceinfo.js View 3 chunks +5 lines, -7 lines 0 comments Download
A + test/debugger/debug/function-source.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/regress/regress-prepare-break-while-recompile.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/debugger/test-api.js View 1 7 chunks +67 lines, -42 lines 0 comments Download
D test/mjsunit/debug-sourceinfo.js View 1 chunk +0 lines, -201 lines 0 comments Download
D test/mjsunit/function-source.js View 1 chunk +0 lines, -49 lines 0 comments Download
D test/mjsunit/regress/regress-prepare-break-while-recompile.js View 1 chunk +0 lines, -71 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (12 generated)
jgruber
4 years, 1 month ago (2016-11-16 10:41:15 UTC) #4
Yang
lgtm https://codereview.chromium.org/2508853003/diff/1/test/debugger/test-api.js File test/debugger/test-api.js (right): https://codereview.chromium.org/2508853003/diff/1/test/debugger/test-api.js#newcode175 test/debugger/test-api.js:175: } do we want to clear the set ...
4 years, 1 month ago (2016-11-16 14:32:00 UTC) #7
jgruber
https://codereview.chromium.org/2508853003/diff/1/test/debugger/test-api.js File test/debugger/test-api.js (right): https://codereview.chromium.org/2508853003/diff/1/test/debugger/test-api.js#newcode175 test/debugger/test-api.js:175: } On 2016/11/16 14:31:59, Yang wrote: > do we ...
4 years, 1 month ago (2016-11-16 15:18:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508853003/20001
4 years, 1 month ago (2016-11-17 09:31:45 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 09:33:59 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:37:45 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c8a4155aad5cae6fd1148d72663cfa2e68f9637
Cr-Commit-Position: refs/heads/master@{#41064}

Powered by Google App Engine
This is Rietveld 408576698