[debug-wrapper] LiveEdit, frame.restart(), breakpoints

[debug-wrapper] LiveEdit, frame.restart(), breakpoints

This adds access to the LiveEdit API object, frame.restart(), and
various breakpoint setters. The LiveEdit API still depends on the JS
debugging context and blocks its removal; but it should be removed
once LiveEdit is rewritten in the midterm.

BUG=v8:5530
Committed: https://crrev.com/4fb4f3408c9f45d6f550517cd35777098ebb6be4
Cr-Commit-Position: refs/heads/master@{#41062}

[jgruber, 2016-11-16 08:13:28]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 08:13:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 08:33:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 08:33:16]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/16310)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[jgruber, 2016-11-16 09:00:40]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[jgruber, 2016-11-16 09:00:41]

Still working on fixing the test failure but feel free to take a look in the
meantime.

[jgruber, 2016-11-16 09:28:35]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 09:28:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 09:53:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 09:53:14]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-11-16 10:00:42]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 10:00:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 10:25:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 10:25:40]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-11-17 07:54:08]

lgtm if all tests pass

https://codereview.chromium.org/2503293002/diff/40001/src/debug/liveedit.js
File src/debug/liveedit.js (right):

https://codereview.chromium.org/2503293002/diff/40001/src/debug/liveedit.js#n...
src/debug/liveedit.js:1124: %InstallToContext(["debug_live_edit", LiveEdit]);
I don't think we need a context slot for this. We can simply load it from the
debug context's global object.

If you want to make things a bit shorter, you could also store it on
global.LiveEdit here.

[jgruber, 2016-11-17 08:14:15]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 08:14:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-11-17 08:15:04]

https://codereview.chromium.org/2503293002/diff/40001/src/debug/liveedit.js
File src/debug/liveedit.js (right):

https://codereview.chromium.org/2503293002/diff/40001/src/debug/liveedit.js#n...
src/debug/liveedit.js:1124: %InstallToContext(["debug_live_edit", LiveEdit]);
On 2016/11/17 07:54:08, Yang wrote:
> I don't think we need a context slot for this. We can simply load it from the
> debug context's global object.
> 
> If you want to make things a bit shorter, you could also store it on
> global.LiveEdit here.

Good point, this really simplifies things. Done.

[Yang, 2016-11-17 08:25:24]

On 2016/11/17 08:15:04, jgruber wrote:
> https://codereview.chromium.org/2503293002/diff/40001/src/debug/liveedit.js
> File src/debug/liveedit.js (right):
> 
>
https://codereview.chromium.org/2503293002/diff/40001/src/debug/liveedit.js#n...
> src/debug/liveedit.js:1124: %InstallToContext(["debug_live_edit", LiveEdit]);
> On 2016/11/17 07:54:08, Yang wrote:
> > I don't think we need a context slot for this. We can simply load it from
the
> > debug context's global object.
> > 
> > If you want to make things a bit shorter, you could also store it on
> > global.LiveEdit here.
> 
> Good point, this really simplifies things. Done.

lgtm

[commit-bot: I haz the power, 2016-11-17 08:39:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 08:39:18]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-11-17 08:40:53]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2016-11-17 08:40:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 08:43:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-17 22:37:37]

Description was changed from

==========
[debug-wrapper] LiveEdit, frame.restart(), breakpoints

This adds access to the LiveEdit API object, frame.restart(), and
various breakpoint setters. The LiveEdit API still depends on the JS
debugging context and blocks its removal; but it should be removed
once LiveEdit is rewritten in the midterm.

BUG=v8:5530
==========

to

==========
[debug-wrapper] LiveEdit, frame.restart(), breakpoints

This adds access to the LiveEdit API object, frame.restart(), and
various breakpoint setters. The LiveEdit API still depends on the JS
debugging context and blocks its removal; but it should be removed
once LiveEdit is rewritten in the midterm.

BUG=v8:5530

Committed: https://crrev.com/4fb4f3408c9f45d6f550517cd35777098ebb6be4
Cr-Commit-Position: refs/heads/master@{#41062}
==========

[commit-bot: I haz the power, 2016-11-17 22:37:38]

Patchset 4 (id:??) landed as
https://crrev.com/4fb4f3408c9f45d6f550517cd35777098ebb6be4
Cr-Commit-Position: refs/heads/master@{#41062}