Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2508763002: Add Cross Process Guests feature switch to about:flags. (Closed)

Created:
4 years, 1 month ago by avallee
Modified:
4 years, 1 month ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Cross Process Guests feature switch to about:flags. BUG=665722 Committed: https://crrev.com/168224b127e006014559eaba13f711121143092c Cr-Commit-Position: refs/heads/master@{#432741}

Patch Set 1 #

Patch Set 2 : Add missing info to histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
avallee
PTAL. sky: chrome/ asvitkine: histogram.
4 years, 1 month ago (2016-11-16 17:23:30 UTC) #8
sky
LGTM
4 years, 1 month ago (2016-11-16 17:57:04 UTC) #9
Alexei Svitkine (slow)
lgtm
4 years, 1 month ago (2016-11-16 18:15:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508763002/20001
4 years, 1 month ago (2016-11-16 19:33:03 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/69025)
4 years, 1 month ago (2016-11-16 21:30:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508763002/20001
4 years, 1 month ago (2016-11-17 02:41:33 UTC) #19
commit-bot: I haz the power
Failed to apply patch for chrome/app/generated_resources.grd: While running git apply --index -p1; error: patch failed: ...
4 years, 1 month ago (2016-11-17 04:33:51 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 04:39:54 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/168224b127e006014559eaba13f711121143092c
Cr-Commit-Position: refs/heads/master@{#432741}

Powered by Google App Engine
This is Rietveld 408576698