Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2508763002: Add Cross Process Guests feature switch to about:flags. (Closed)
Patch Set: Add missing info to histograms.xml Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2101 matching lines...) Expand 10 before | Expand all | Expand 10 after
2112 FEATURE_VALUE_TYPE(features::kConsistentOmniboxGeolocation)}, 2112 FEATURE_VALUE_TYPE(features::kConsistentOmniboxGeolocation)},
2113 {"concurrent-background-loading-on-svelte", 2113 {"concurrent-background-loading-on-svelte",
2114 IDS_FLAGS_OFFLINE_PAGES_SVELTE_CONCURRENT_LOADING_NAME, 2114 IDS_FLAGS_OFFLINE_PAGES_SVELTE_CONCURRENT_LOADING_NAME,
2115 IDS_FLAGS_OFFLINE_PAGES_SVELTE_CONCURRENT_LOADING_DESCRIPTION, kOsAndroid, 2115 IDS_FLAGS_OFFLINE_PAGES_SVELTE_CONCURRENT_LOADING_DESCRIPTION, kOsAndroid,
2116 FEATURE_VALUE_TYPE( 2116 FEATURE_VALUE_TYPE(
2117 offline_pages::kOfflinePagesSvelteConcurrentLoadingFeature)}, 2117 offline_pages::kOfflinePagesSvelteConcurrentLoadingFeature)},
2118 #endif 2118 #endif
2119 // NOTE: Adding new command-line switches requires adding corresponding 2119 // NOTE: Adding new command-line switches requires adding corresponding
2120 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2120 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2121 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2121 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2122 {"cross-process-guests", IDS_FLAGS_CROSS_PROCESS_GUEST_VIEW_ISOLATION_NAME,
2123 IDS_FLAGS_CROSS_PROCESS_GUEST_VIEW_ISOLATION_DESCRIPTION, kOsDesktop,
2124 FEATURE_VALUE_TYPE(features::kGuestViewCrossProcessFrames)},
2122 }; 2125 };
2123 2126
2124 class FlagsStateSingleton { 2127 class FlagsStateSingleton {
2125 public: 2128 public:
2126 FlagsStateSingleton() 2129 FlagsStateSingleton()
2127 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 2130 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
2128 ~FlagsStateSingleton() {} 2131 ~FlagsStateSingleton() {}
2129 2132
2130 static FlagsStateSingleton* GetInstance() { 2133 static FlagsStateSingleton* GetInstance() {
2131 return base::Singleton<FlagsStateSingleton>::get(); 2134 return base::Singleton<FlagsStateSingleton>::get();
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
2317 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2320 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2318 2321
2319 const FeatureEntry* GetFeatureEntries(size_t* count) { 2322 const FeatureEntry* GetFeatureEntries(size_t* count) {
2320 *count = arraysize(kFeatureEntries); 2323 *count = arraysize(kFeatureEntries);
2321 return kFeatureEntries; 2324 return kFeatureEntries;
2322 } 2325 }
2323 2326
2324 } // namespace testing 2327 } // namespace testing
2325 2328
2326 } // namespace about_flags 2329 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698