Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2508643002: Convert Histograms to CSV. (Closed)

Created:
4 years, 1 month ago by benjhayden
Modified:
4 years, 1 month ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Convert Histograms to CSV. Currently, results2.html is the only way to view TBMv2 metric results. results2 is increasingly powerful, but there will always be use-cases that it can't support. Also, sometimes results2 is too powerful and Histograms are too deep. Sometimes you just want a spreadsheet. This CL implements a script histograms2csv and a button in results2 that produce a CSV file that can then be opened in Google Sheets or similar. Diagnostics are dropped, but most Histogram fields are exported, including all statisticsScalars and all IterationInfo fields including storyGroupingKeys. Neither the script nor the button perform any grouping/merging of Histograms. For that, see tracing/bin/merge_histograms. https://screenshot.googleplex.com/GbMwymYtCjP.png Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/00b74ac3700b580b9c85a3d2495f8ddf04995bb4

Patch Set 1 : . #

Patch Set 2 : CSVBuilder #

Patch Set 3 : leafHistograms #

Patch Set 4 : fix #

Patch Set 5 : test #

Patch Set 6 : fixes #

Patch Set 7 : simplify test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+353 lines, -38 lines) Patch
A tracing/bin/histograms2csv View 1 2 3 4 5 1 chunk +46 lines, -0 lines 0 comments Download
M tracing/trace_viewer.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
A tracing/tracing/value/csv_builder.html View 1 2 3 4 1 chunk +138 lines, -0 lines 0 comments Download
A tracing/tracing/value/csv_builder_test.html View 1 2 3 4 5 6 1 chunk +61 lines, -0 lines 0 comments Download
M tracing/tracing/value/histogram.html View 1 2 3 4 4 chunks +40 lines, -34 lines 0 comments Download
M tracing/tracing/value/histogram_set.html View 1 2 chunks +2 lines, -3 lines 0 comments Download
A tracing/tracing/value/histograms_to_csv_cmdline.html View 1 2 3 4 5 1 chunk +22 lines, -0 lines 0 comments Download
M tracing/tracing/value/ui/histogram_set_table.html View 1 2 3 5 chunks +31 lines, -1 line 0 comments Download
M tracing/tracing/value/ui/histogram_set_table_row.html View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
benjhayden
PTAL :-)
4 years, 1 month ago (2016-11-16 01:16:09 UTC) #9
eakuefner
lgtm
4 years, 1 month ago (2016-11-18 21:27:23 UTC) #12
oystein (OOO til 10th of July)
Awesome, lgtm :)
4 years, 1 month ago (2016-11-18 23:02:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508643002/180001
4 years, 1 month ago (2016-11-21 20:36:18 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Mac%20Tryserver/builds/5747)
4 years, 1 month ago (2016-11-21 20:56:49 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508643002/180002
4 years, 1 month ago (2016-11-21 21:23:15 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 21:43:14 UTC) #24
Message was sent while issue was closed.
Committed patchset #7 (id:180002) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698