Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: tracing/tracing/value/histogram.html

Issue 2508643002: Convert Histograms to CSV. (Closed)
Patch Set: simplify test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/csv_builder_test.html ('k') | tracing/tracing/value/histogram_set.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/histogram.html
diff --git a/tracing/tracing/value/histogram.html b/tracing/tracing/value/histogram.html
index 7213b2bb0d9c49a5cf6a549d8f5e287018189470..f775b5e8a5cd54b03c3a4ba4745fbe8ca0e1823b 100644
--- a/tracing/tracing/value/histogram.html
+++ b/tracing/tracing/value/histogram.html
@@ -24,6 +24,30 @@ tr.exportTo('tr.v', function() {
var MERGED_FROM_DIAGNOSTIC_KEY = 'merged from';
+ /**
+ * Converts the given percent to a string in the format specified above.
+ * @param {number} percent The percent must be between 0.0 and 1.0.
+ * @return {string}
+ */
+ function percentToString(percent) {
+ if (percent < 0 || percent > 1)
+ throw new Error('Percent must be between 0.0 and 1.0');
+ switch (percent) {
+ case 0:
+ return '000';
+ case 1:
+ return '100';
+ }
+ var str = percent.toString();
+ if (str[1] !== '.')
+ throw new Error('Unexpected percent');
+ // Pad short strings with zeros.
+ str = str + '0'.repeat(Math.max(4 - str.length, 0));
+ if (str.length > 4)
+ str = str.slice(0, 4) + '_' + str.slice(4);
+ return '0' + str.slice(2);
+ }
+
class HistogramBin {
/**
* @param {!tr.b.Range} range
@@ -332,17 +356,16 @@ tr.exportTo('tr.v', function() {
var valuesToSkip = Math.floor((this.numValues - 1) * percent);
for (var bin of this.allBins) {
valuesToSkip -= bin.count;
- if (valuesToSkip < 0) {
- if (bin.range.min === -Number.MAX_VALUE) {
- return bin.range.max;
- } else if (bin.range.max === Number.MAX_VALUE) {
- return bin.range.min;
- } else {
- return bin.range.center;
- }
+ if (valuesToSkip >= 0) continue;
+ if (bin.range.min === -Number.MAX_VALUE) {
+ return bin.range.max;
+ } else if (bin.range.max === Number.MAX_VALUE) {
+ return bin.range.min;
+ } else {
+ return bin.range.center;
}
}
- throw new Error('Unreachable');
+ return this.allBins[this.allBins.length - 1].range.min;
}
getBinForValue(value) {
@@ -503,28 +526,6 @@ tr.exportTo('tr.v', function() {
}
return stat;
}
- /**
- * Converts the given percent to a string in the format specified above.
- * @param {number} percent The percent must be between 0.0 and 1.0.
- */
- function percentToString(percent) {
- if (percent < 0 || percent > 1)
- throw new Error('Percent must be between 0.0 and 1.0');
- switch (percent) {
- case 0:
- return '000';
- case 1:
- return '100';
- }
- var str = percent.toString();
- if (str[1] !== '.')
- throw new Error('Unexpected percent');
- // Pad short strings with zeros.
- str = str + '0'.repeat(Math.max(4 - str.length, 0));
- if (str.length > 4)
- str = str.slice(0, 4) + '_' + str.slice(4);
- return '0' + str.slice(2);
- }
var results = new Map();
for (var [stat, option] of this.summaryOptions) {
@@ -1089,10 +1090,15 @@ tr.exportTo('tr.v', function() {
tr.b.Unit.byName.count.unitName,
HistogramBinBoundaries.createExponential(1, 1e3, 20));
+ DEFAULT_BOUNDARIES_FOR_UNIT.set(
+ tr.b.Unit.byName.sigma.unitName,
+ HistogramBinBoundaries.createLinear(-5, 5, 50));
+
return {
- Histogram: Histogram,
- HistogramBinBoundaries: HistogramBinBoundaries,
- MERGED_FROM_DIAGNOSTIC_KEY: MERGED_FROM_DIAGNOSTIC_KEY
+ Histogram,
+ HistogramBinBoundaries,
+ MERGED_FROM_DIAGNOSTIC_KEY,
+ percentToString,
};
});
</script>
« no previous file with comments | « tracing/tracing/value/csv_builder_test.html ('k') | tracing/tracing/value/histogram_set.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698