Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2508563003: Printing: Load the source PDF only once. (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, dsinclair
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Printing: Load the source PDF only once. Instead of loading the PDF once per operation, which is slightly more than once per page. Committed: https://crrev.com/fe899c8e19e6be990d0254f040f14c4a6d4cee70 Cr-Commit-Position: refs/heads/master@{#432594}

Patch Set 1 #

Patch Set 2 : Better documentation, fix potential leak. #

Patch Set 3 : Fix typos and such #

Patch Set 4 : Found a better stopping point to release the handle, rename IPC message to make grepping easier #

Patch Set 5 : Fix IPC name typo #

Patch Set 6 : More renaming #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -150 lines) Patch
M chrome/browser/printing/pdf_to_emf_converter.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_preview_pdf_generated_browsertest.cc View 3 chunks +14 lines, -22 lines 0 comments Download
M chrome/common/chrome_utility_printing_messages.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/service_utility_process_host.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/printing_handler.h View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/utility/printing_handler.cc View 1 2 3 4 5 10 chunks +32 lines, -31 lines 0 comments Download
M pdf/pdf.h View 1 2 4 chunks +21 lines, -19 lines 0 comments Download
M pdf/pdf.cc View 4 chunks +32 lines, -21 lines 0 comments Download
M pdf/pdf_engine.h View 1 3 chunks +11 lines, -11 lines 0 comments Download
M pdf/pdfium/pdfium_engine.h View 2 chunks +6 lines, -7 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 2 4 chunks +28 lines, -35 lines 0 comments Download

Messages

Total messages: 28 (20 generated)
Lei Zhang
4 years, 1 month ago (2016-11-16 00:10:52 UTC) #4
Lei Zhang
and +tsepez because I renamed an IPC message.
4 years, 1 month ago (2016-11-16 01:05:39 UTC) #10
dsinclair
lgtm
4 years, 1 month ago (2016-11-16 14:36:45 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508563003/100001
4 years, 1 month ago (2016-11-16 18:28:12 UTC) #22
Tom Sepez
RS LGTM
4 years, 1 month ago (2016-11-16 18:40:02 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508563003/100001
4 years, 1 month ago (2016-11-16 19:28:11 UTC) #25
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 1 month ago (2016-11-16 19:38:37 UTC) #26
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 19:53:50 UTC) #28
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/fe899c8e19e6be990d0254f040f14c4a6d4cee70
Cr-Commit-Position: refs/heads/master@{#432594}

Powered by Google App Engine
This is Rietveld 408576698