Printing: Load the source PDF only once.

chrome/browser/printing/print_preview_pdf_generated_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <fstream>
 #include <iostream>
 #include <iterator>
@@ skipping 317 matching lines @@
     // Need to check whether the save was successful. Ending the loop only
     // means the save was attempted.
     base::File pdf_file(
         pdf_file_save_path_, base::File::FLAG_OPEN | base::File::FLAG_READ);
     ASSERT_TRUE(pdf_file.IsValid());
   }
 
   // Converts the PDF to a PNG file so that the layout test can do an image
   // diff on this image and a reference image.
   void PdfToPng() {
+    std::string pdf_data;
+    ASSERT_TRUE(base::ReadFileToString(pdf_file_save_path_, &pdf_data));
+
     int num_pages;
     double max_width_in_points = 0;
-    std::vector<uint8_t> bitmap_data;
-    double total_height_in_pixels = 0;
-    std::string pdf_data;
-
-    ASSERT_TRUE(base::ReadFileToString(pdf_file_save_path_, &pdf_data));
-    ASSERT_TRUE(chrome_pdf::GetPDFDocInfo(pdf_data.data(),
-                                          pdf_data.size(),
-                                          &num_pages,
-                                          &max_width_in_points));
-
+    void* pdf_handle = nullptr;
+    ASSERT_TRUE(chrome_pdf::GetPDFDocInfo(pdf_data.data(), pdf_data.size(),
+                                          &num_pages, &max_width_in_points,
+                                          &pdf_handle));
     ASSERT_GT(num_pages, 0);
     double max_width_in_pixels =
         ConvertUnitDouble(max_width_in_points, kPointsPerInch, kDpi);
 
+    std::vector<uint8_t> bitmap_data;
+    double total_height_in_pixels = 0;
     for (int i = 0; i < num_pages; ++i) {
       double width_in_points, height_in_points;
-      ASSERT_TRUE(chrome_pdf::GetPDFPageSizeByIndex(pdf_data.data(),
-                                                    pdf_data.size(),
-                                                    i,
-                                                    &width_in_points,
-                                                    &height_in_points));
+      ASSERT_TRUE(chrome_pdf::GetPDFPageSizeByIndex(
+          pdf_handle, i, &width_in_points, &height_in_points));
 
       double width_in_pixels = ConvertUnitDouble(
           width_in_points, kPointsPerInch, kDpi);
       double height_in_pixels = ConvertUnitDouble(
           height_in_points, kPointsPerInch, kDpi);
 
       // The image will be rotated if |width_in_pixels| is greater than
       // |height_in_pixels|. This is because the page will be rotated to fit
       // within a piece of paper. Therefore, |width_in_pixels| and
       // |height_in_pixels| have to be swapped or else they won't reflect the
@@ skipping 10 matching lines @@
           settings.area().height() > int_max / (kColorChannels *
               settings.area().width())) {
         FAIL() << "The dimensions of the image are too large."
                << "Decrease the DPI or the dimensions of the image.";
       }
 
       std::vector<uint8_t> page_bitmap_data(
           kColorChannels * settings.area().size().GetArea());
 
       ASSERT_TRUE(chrome_pdf::RenderPDFPageToBitmap(
-          pdf_data.data(),
-          pdf_data.size(),
-          i,
-          page_bitmap_data.data(),
-          settings.area().size().width(),
-          settings.area().size().height(),
-          settings.dpi(),
-          true));
+          pdf_handle, i, page_bitmap_data.data(),
+          settings.area().size().width(), settings.area().size().height(),
+          settings.dpi(), true));
       FillPng(&page_bitmap_data,
               width_in_pixels,
               max_width_in_pixels,
               settings.area().size().height());
       bitmap_data.insert(bitmap_data.end(),
                          page_bitmap_data.begin(),
                          page_bitmap_data.end());
     }
 
+    chrome_pdf::ReleasePDFHandle(pdf_handle);
     CreatePng(bitmap_data, max_width_in_pixels, total_height_in_pixels);
   }
 
   // Fills out a bitmap with whitespace so that the image will correctly fit
   // within a PNG that is wider than the bitmap itself.
   void FillPng(std::vector<uint8_t>* bitmap,
                int current_width,
                int desired_width,
                int height) {
     ASSERT_TRUE(bitmap);
@@ skipping 223 matching lines @@
     // waiting for this message and start waiting for the image data.
     std::cout << "#EOF\n";
     std::cout.flush();
 
     SendPng();
     Reset();
   }
 }
 
 }  // namespace printing