Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2508553002: generate_gradle.py: Add support for junit and java_binary targets (Closed)

Created:
4 years, 1 month ago by agrieve
Modified:
4 years, 1 month ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

generate_gradle.py: Add support for junit and java_binary targets Rather than add all the features required by robolectric, this adds a new "gradle_treat_as_prebuilt" flag that is set on a few targets. BUG=620034 Committed: https://crrev.com/2cefaf65d6362aadc536c1224e9981036cfb716f Cr-Commit-Position: refs/heads/master@{#432608}

Patch Set 1 #

Patch Set 2 : update docs/android_studio.md to no long say junit doesn't work #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -40 lines) Patch
M build/android/gradle/build.gradle.jinja View 4 chunks +43 lines, -12 lines 0 comments Download
M build/android/gradle/generate_gradle.py View 9 chunks +41 lines, -14 lines 0 comments Download
M build/android/gyp/write_build_config.py View 4 chunks +39 lines, -13 lines 0 comments Download
M build/config/android/internal_rules.gni View 2 chunks +12 lines, -0 lines 0 comments Download
M docs/android_studio.md View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/robolectric/BUILD.gn View 4 chunks +12 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (12 generated)
agrieve
wnwen: Please review mikecase: for robolectric
4 years, 1 month ago (2016-11-15 22:06:30 UTC) #2
Peter Wen
lgtm This is a whole lot more comprehensive than my original CL. Thanks Andrew! I'll ...
4 years, 1 month ago (2016-11-15 22:18:06 UTC) #3
mikecase (-- gone --)
robolectric lgtm
4 years, 1 month ago (2016-11-16 20:05:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508553002/20001
4 years, 1 month ago (2016-11-16 20:12:32 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 20:19:58 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2cefaf65d6362aadc536c1224e9981036cfb716f Cr-Commit-Position: refs/heads/master@{#432608}
4 years, 1 month ago (2016-11-16 20:25:11 UTC) #18
dgn
4 years, 1 month ago (2016-11-17 13:14:08 UTC) #19
Message was sent while issue was closed.
Wohoo! thank you very much! 😀

Powered by Google App Engine
This is Rietveld 408576698