Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 2507473002: generate_gradle.py: Build all generated files (not just .srcjars) (Closed)

Created:
4 years, 1 month ago by agrieve
Modified:
4 years, 1 month ago
Reviewers:
Peter Wen
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

generate_gradle.py: Build all generated files (not just .srcjars) BUG=620034 NOTRY=true Committed: https://crrev.com/e8f1ece7fb9ea2f93b83019ebf250172434c6cac Cr-Commit-Position: refs/heads/master@{#432529}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -11 lines) Patch
M build/android/gradle/generate_gradle.py View 5 chunks +20 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (8 generated)
agrieve
On 2016/11/15 16:50:51, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:wnwen@chromium.org 🐴
4 years, 1 month ago (2016-11-15 16:50:56 UTC) #3
Peter Wen
lgtm Is this for eventually marking some third parties as prebuilts?
4 years, 1 month ago (2016-11-15 16:56:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507473002/1
4 years, 1 month ago (2016-11-16 15:04:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/68764)
4 years, 1 month ago (2016-11-16 16:35:12 UTC) #8
jbudorick
On 2016/11/16 16:35:12, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 1 month ago (2016-11-16 16:39:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507473002/1
4 years, 1 month ago (2016-11-16 17:08:41 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 17:14:30 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 17:19:06 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8f1ece7fb9ea2f93b83019ebf250172434c6cac
Cr-Commit-Position: refs/heads/master@{#432529}

Powered by Google App Engine
This is Rietveld 408576698