Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: components/browser_sync/profile_sync_components_factory_impl.cc

Issue 2508263003: [sync] skeleton implementation of AutocompleteSyncBridge (Closed)
Patch Set: Address Max and Pavel's comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_sync/profile_sync_components_factory_impl.cc
diff --git a/components/browser_sync/profile_sync_components_factory_impl.cc b/components/browser_sync/profile_sync_components_factory_impl.cc
index c4332e02bdc969cd0fa5b05a11bd7e5b61822f33..3715d1e605c5d67bdbc6352f990f3522e5fca297 100644
--- a/components/browser_sync/profile_sync_components_factory_impl.cc
+++ b/components/browser_sync/profile_sync_components_factory_impl.cc
@@ -155,9 +155,16 @@ void ProfileSyncComponentsFactoryImpl::RegisterCommonDataTypes(
// Autofill sync is enabled by default. Register unless explicitly
Mathieu 2016/11/23 12:47:21 I wish this was called "Autocomplete" now. What we
Patrick Noland 2016/11/29 00:09:50 Done.
// disabled.
if (!disabled_types.Has(syncer::AUTOFILL)) {
- sync_service->RegisterDataTypeController(
- base::MakeUnique<AutofillDataTypeController>(
- db_thread_, error_callback, sync_client_, web_data_service_));
+ if (base::FeatureList::IsEnabled(switches::kSyncUSSAutocomplete)) {
+ sync_service->RegisterDataTypeController(
+ base::MakeUnique<ModelTypeController>(
+ syncer::AUTOFILL, base::Bind(&base::debug::DumpWithoutCrashing),
+ sync_client_, db_thread_));
+ } else {
+ sync_service->RegisterDataTypeController(
+ base::MakeUnique<AutofillDataTypeController>(
+ db_thread_, error_callback, sync_client_, web_data_service_));
+ }
}
// Autofill profile sync is enabled by default. Register unless explicitly

Powered by Google App Engine
This is Rietveld 408576698