[sync] skeleton implementation of AutocompleteSyncBridge

components/sync/driver/model_type_controller.cc

Index: components/sync/driver/model_type_controller.cc
diff --git a/components/sync/driver/model_type_controller.cc b/components/sync/driver/model_type_controller.cc
index 313c8c4d5b3ba5a97f6ce1fca7230ed79ba061df..e813cb3a0e8f5a8c9513212d661f56db39e80af1 100644
--- a/components/sync/driver/model_type_controller.cc
+++ b/components/sync/driver/model_type_controller.cc
@@ -26,6 +26,46 @@
 
 namespace syncer {
 
+namespace {
+
+// static

[maxbogue, 2016/11/22 19:07:23]

remove

[Patrick Noland, 2016/11/29 00:09:50]

Done.

+void CallOnSyncStartingHelper(
+    SyncClient* sync_client,
+    ModelType type,
+    std::unique_ptr<DataTypeErrorHandler> error_handler,
+    ModelTypeChangeProcessor::StartCallback callback) {
+  base::WeakPtr<ModelTypeSyncBridge> bridge =
+      sync_client->GetSyncBridgeForModelType(type);
+  if (bridge) {
+    bridge->OnSyncStarting(std::move(error_handler), callback);
+  }
+}
+
+// static

[maxbogue, 2016/11/22 19:07:23]

remove

[Patrick Noland, 2016/11/29 00:09:51]

Done.

+void CallGetAllNodesHelper(SyncClient* sync_client,
+                           ModelType type,
+                           DataTypeController::AllNodesCallback callback) {
+  base::WeakPtr<ModelTypeSyncBridge> bridge =
+      sync_client->GetSyncBridgeForModelType(type);
+  if (bridge) {
+    ModelTypeDebugInfo::GetAllNodes(bridge, callback);
+  }
+}
+
+// static

[maxbogue, 2016/11/22 19:07:23]

remove

[Patrick Noland, 2016/11/29 00:09:51]

Done.

+void CallGetStatusCountersHelper(
+    SyncClient* sync_client,
+    ModelType type,
+    const DataTypeController::StatusCountersCallback& callback) {
+  base::WeakPtr<ModelTypeSyncBridge> bridge =
+      sync_client->GetSyncBridgeForModelType(type);
+  if (bridge) {
+    ModelTypeDebugInfo::GetStatusCounters(bridge, callback);
+  }
+}
+
+}  // namespace
+
 ModelTypeController::ModelTypeController(
     ModelType type,
     const base::Closure& dump_stack,
@@ -69,26 +109,21 @@ void ModelTypeController::LoadModels(
 
   // Start the type processor on the model thread.
   model_thread_->PostTask(
-      FROM_HERE, base::Bind(&ModelTypeSyncBridge::OnSyncStarting,
-                            sync_client_->GetSyncBridgeForModelType(type()),
+      FROM_HERE, base::Bind(&CallOnSyncStartingHelper, sync_client_, type(),
                             base::Passed(CreateErrorHandler()), callback));
 }
 
 void ModelTypeController::GetAllNodes(const AllNodesCallback& callback) {
-  base::WeakPtr<ModelTypeSyncBridge> bridge =
-      sync_client_->GetSyncBridgeForModelType(type());
-  model_thread_->PostTask(FROM_HERE,
-                          base::Bind(&ModelTypeDebugInfo::GetAllNodes, bridge,
-                                     BindToCurrentThread(callback)));
+  model_thread_->PostTask(
+      FROM_HERE, base::Bind(&CallGetAllNodesHelper, sync_client_, type(),
+                            BindToCurrentThread(callback)));
 }
 
 void ModelTypeController::GetStatusCounters(
     const StatusCountersCallback& callback) {
-  base::WeakPtr<ModelTypeSyncBridge> bridge =
-      sync_client_->GetSyncBridgeForModelType(type());
   model_thread_->PostTask(
-      FROM_HERE,
-      base::Bind(&ModelTypeDebugInfo::GetStatusCounters, bridge, callback));
+      FROM_HERE, base::Bind(&CallGetStatusCountersHelper, sync_client_, type(),
+                            BindToCurrentThread(callback)));

[maxbogue, 2016/11/22 19:07:23]

Whoops, I missed Pavel's comment before... it's actually not needed, as PSS
binds it: 

https://cs.chromium.org/chromium/src/components/browser_sync/profile_sync_ser...

it's also mentioned in the method comment:

https://cs.chromium.org/chromium/src/components/sync/driver/data_type_control...

I can't remember why the other one doesn't, but yeah. Don't need it here.

[Patrick Noland, 2016/11/29 00:09:51]

Done.

 }
 
 void ModelTypeController::LoadModelsDone(ConfigureResult result,