Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: media/gpu/android_video_decode_accelerator.cc

Issue 2508203004: Add hints for potential overlay promotion on android. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/gpu/android_video_decode_accelerator.cc
diff --git a/media/gpu/android_video_decode_accelerator.cc b/media/gpu/android_video_decode_accelerator.cc
index de67510f8e0cf7ef6798dc8bd661536951cb5bc5..e94cb5e09cb715225bdf249092d17440e56707d4 100644
--- a/media/gpu/android_video_decode_accelerator.cc
+++ b/media/gpu/android_video_decode_accelerator.cc
@@ -825,12 +825,13 @@ void AndroidVideoDecodeAccelerator::SendDecodedFrameToClient(
if (size_changed)
picture_buffer.set_size(size_);
- const bool allow_overlay = picture_buffer_manager_.ArePicturesOverlayable();
- UMA_HISTOGRAM_BOOLEAN("Media.AVDA.FrameSentAsOverlay", allow_overlay);
+ const bool surface_view = picture_buffer_manager_.ArePicturesOverlayable();
+ UMA_HISTOGRAM_BOOLEAN("Media.AVDA.FrameSentAsOverlay", surface_view);
// TODO(hubbe): Insert the correct color space. http://crbug.com/647725
Picture picture(picture_buffer_id, bitstream_id, gfx::Rect(size_),
- gfx::ColorSpace(), allow_overlay);
+ gfx::ColorSpace(), true /* allow_overlay */);
picture.set_size_changed(size_changed);
+ picture.set_surface_texture(!surface_view);
liberato (no reviews please) 2016/11/19 18:25:52 this is where the "backed by surface texture" flag
// Notify picture ready before calling UseCodecBufferForPictureBuffer() since
// that process may be slow and shouldn't delay delivery of the frame to the

Powered by Google App Engine
This is Rietveld 408576698