Add hints for potential overlay promotion on android.

media/gpu/android_video_decode_accelerator.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/gpu/android_video_decode_accelerator.h"
 
 #include <stddef.h>
 
 #include <memory>
 
@@ skipping 807 matching lines @@
     NOTIFY_ERROR(PLATFORM_FAILURE,
                  "Can't find PictureBuffer id: " << picture_buffer_id);
     return;
   }
 
   PictureBuffer& picture_buffer = it->second;
   const bool size_changed = picture_buffer.size() != size_;
   if (size_changed)
     picture_buffer.set_size(size_);
 
-  const bool allow_overlay = picture_buffer_manager_.ArePicturesOverlayable();
-  UMA_HISTOGRAM_BOOLEAN("Media.AVDA.FrameSentAsOverlay", allow_overlay);
+  const bool surface_view = picture_buffer_manager_.ArePicturesOverlayable();
+  UMA_HISTOGRAM_BOOLEAN("Media.AVDA.FrameSentAsOverlay", surface_view);
   // TODO(hubbe): Insert the correct color space. http://crbug.com/647725
   Picture picture(picture_buffer_id, bitstream_id, gfx::Rect(size_),
-                  gfx::ColorSpace(), allow_overlay);
+                  gfx::ColorSpace(), true /* allow_overlay */);
   picture.set_size_changed(size_changed);
+  picture.set_surface_texture(!surface_view);

[liberato (no reviews please), 2016/11/19 18:25:52]

this is where the "backed by surface texture" flag is set initially.

the flag follows roughly this: picture (AVDA) => VideoFrameMetaData
(GpuVideoDecoder) => TextureMailbox (VideoResourceUpdater) => Resource
(ResourceUpdater) => TransferableResource => Resource => overlay_processor.

 
   // Notify picture ready before calling UseCodecBufferForPictureBuffer() since
   // that process may be slow and shouldn't delay delivery of the frame to the
   // renderer. The picture is only used on the same thread as this method is
   // called, so it is safe to do this.
   NotifyPictureReady(picture);
 
   // Connect the PictureBuffer to the decoded frame.
   picture_buffer_manager_.UseCodecBufferForPictureBuffer(codec_buffer_index,
                                                          picture_buffer);
@@ skipping 773 matching lines @@
       !media_codec_->SetSurface(codec_config_->surface_.j_surface().obj())) {
     NOTIFY_ERROR(PLATFORM_FAILURE, "MediaCodec failed to switch surfaces.");
     return false;
   }
 
   pending_surface_id_.reset();
   return true;
 }
 
 }  // namespace media