Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2508153003:
MacViews: Disable NativeWidgetMacTest.WindowModalSheet. (Closed)
|
Created:
4 years, 1 month ago by tapted Modified:
4 years, 1 month ago Reviewers:
Evan Stade CC:
chromium-reviews, tfarina, mac-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMacViews: Disable NativeWidgetMacTest.WindowModalSheet.
It seems to fail due to sharding adjustments. A DCHECK is hit in
WidgetOwnerNSWindowAdapter::OnWindowDidChangeOcclusionState() during
closure of the sheet when the parent window receives an asynchronous
occlusion state change from the window server, after the child has its
parent window relationship removed.
This "shouldn't" happen, but sheets (and occulsion states) are weird.
The tests probably should be failing always. It's possibly only
happening on 10.9.
BUG=666503
NOTRY=true
Committed: https://crrev.com/cf8095820e7183dfd786330291460d7ea3b0a94f
Cr-Commit-Position: refs/heads/master@{#433028}
Patch Set 1 #
Messages
Total messages: 21 (13 generated)
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
Description was changed from ========== MacViewS: Disable NativeWidgetMacTest.WindowModalSheet. It seems to fails due to sharding adjustments. A DCHECK is hit in WidgetOwnerNSWindowAdapter::OnWindowDidChangeOcclusionState() during closure of the sheet when the parent window receives an asynchronous occlusion state change from the window server, after the child has its parent window relationship removed. This "shouldn't" happen, but sheets are weird. The tests probably should fail. It's possibly only happening on 10.9. BUG=666503 NOTRY=true ========== to ========== MacViews: Disable NativeWidgetMacTest.WindowModalSheet. It seems to fails due to sharding adjustments. A DCHECK is hit in WidgetOwnerNSWindowAdapter::OnWindowDidChangeOcclusionState() during closure of the sheet when the parent window receives an asynchronous occlusion state change from the window server, after the child has its parent window relationship removed. This "shouldn't" happen, but sheets are weird. The tests probably should fail. It's possibly only happening on 10.9. BUG=666503 NOTRY=true ==========
tapted@chromium.org changed reviewers: + estade@chromium.org
Description was changed from ========== MacViews: Disable NativeWidgetMacTest.WindowModalSheet. It seems to fails due to sharding adjustments. A DCHECK is hit in WidgetOwnerNSWindowAdapter::OnWindowDidChangeOcclusionState() during closure of the sheet when the parent window receives an asynchronous occlusion state change from the window server, after the child has its parent window relationship removed. This "shouldn't" happen, but sheets are weird. The tests probably should fail. It's possibly only happening on 10.9. BUG=666503 NOTRY=true ========== to ========== MacViews: Disable NativeWidgetMacTest.WindowModalSheet. It seems to fail due to sharding adjustments. A DCHECK is hit in WidgetOwnerNSWindowAdapter::OnWindowDidChangeOcclusionState() during closure of the sheet when the parent window receives an asynchronous occlusion state change from the window server, after the child has its parent window relationship removed. This "shouldn't" happen, but sheets (and occulsion states) are weird. The tests probably should be failing always. It's possibly only happening on 10.9. BUG=666503 NOTRY=true ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by tapted@chromium.org
The CQ bit was checked by tapted@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by estade@chromium.org
The CQ bit was checked by estade@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply the patch.
The CQ bit was checked by tapted@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== MacViews: Disable NativeWidgetMacTest.WindowModalSheet. It seems to fail due to sharding adjustments. A DCHECK is hit in WidgetOwnerNSWindowAdapter::OnWindowDidChangeOcclusionState() during closure of the sheet when the parent window receives an asynchronous occlusion state change from the window server, after the child has its parent window relationship removed. This "shouldn't" happen, but sheets (and occulsion states) are weird. The tests probably should be failing always. It's possibly only happening on 10.9. BUG=666503 NOTRY=true ========== to ========== MacViews: Disable NativeWidgetMacTest.WindowModalSheet. It seems to fail due to sharding adjustments. A DCHECK is hit in WidgetOwnerNSWindowAdapter::OnWindowDidChangeOcclusionState() during closure of the sheet when the parent window receives an asynchronous occlusion state change from the window server, after the child has its parent window relationship removed. This "shouldn't" happen, but sheets (and occulsion states) are weird. The tests probably should be failing always. It's possibly only happening on 10.9. BUG=666503 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== MacViews: Disable NativeWidgetMacTest.WindowModalSheet. It seems to fail due to sharding adjustments. A DCHECK is hit in WidgetOwnerNSWindowAdapter::OnWindowDidChangeOcclusionState() during closure of the sheet when the parent window receives an asynchronous occlusion state change from the window server, after the child has its parent window relationship removed. This "shouldn't" happen, but sheets (and occulsion states) are weird. The tests probably should be failing always. It's possibly only happening on 10.9. BUG=666503 NOTRY=true ========== to ========== MacViews: Disable NativeWidgetMacTest.WindowModalSheet. It seems to fail due to sharding adjustments. A DCHECK is hit in WidgetOwnerNSWindowAdapter::OnWindowDidChangeOcclusionState() during closure of the sheet when the parent window receives an asynchronous occlusion state change from the window server, after the child has its parent window relationship removed. This "shouldn't" happen, but sheets (and occulsion states) are weird. The tests probably should be failing always. It's possibly only happening on 10.9. BUG=666503 NOTRY=true Committed: https://crrev.com/cf8095820e7183dfd786330291460d7ea3b0a94f Cr-Commit-Position: refs/heads/master@{#433028} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/cf8095820e7183dfd786330291460d7ea3b0a94f Cr-Commit-Position: refs/heads/master@{#433028} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
