Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Unified Diff: ui/views/widget/native_widget_mac_unittest.mm

Issue 2508153003: MacViews: Disable NativeWidgetMacTest.WindowModalSheet. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/native_widget_mac_unittest.mm
diff --git a/ui/views/widget/native_widget_mac_unittest.mm b/ui/views/widget/native_widget_mac_unittest.mm
index f2e7473693c4f95e1b8475d512bba1365dde43a3..1e0544d2fe7df5989b403b66a699f55c8bfb6079 100644
--- a/ui/views/widget/native_widget_mac_unittest.mm
+++ b/ui/views/widget/native_widget_mac_unittest.mm
@@ -1045,7 +1045,11 @@ TEST_F(NativeWidgetMacTest, NativeWindowChildModalShowHide) {
}
// Tests behavior of window-modal dialogs, displayed as sheets.
-TEST_F(NativeWidgetMacTest, WindowModalSheet) {
+// Disabled: fails due to sharding adjustments. DCHECK fails during closure when
+// the parent window receives an asynchronous occlusion state change from the
+// window server, after the child has its parent window relationship removed.
+// TODO(tapted): Fix it. http://cbrug.com/666503.
+TEST_F(NativeWidgetMacTest, DISABLED_WindowModalSheet) {
NSWindow* native_parent =
MakeNativeParentWithStyle(NSClosableWindowMask | NSTitledWindowMask);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698