Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2508033004: Reduce unnecessary usage of TextCaseSensitivity::TextCaseInsensitive. (Closed)

Created:
4 years, 1 month ago by tkent
Modified:
4 years, 1 month ago
Reviewers:
Yuta Kitamura
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-wtf_chromium.org, caseq+blink_chromium.org, chromium-reviews, dcheng, devtools-reviews_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, gavinp+loader_chromium.org, haraken, Nate Chapin, kinuko+watch, kinuko+fileapi, kozyatinskiy+blink_chromium.org, loading-reviews+fetch_chromium.org, loading-reviews+parser_chromium.org, lushnikov+blink_chromium.org, Mikhail, mlamouri+watch-blink_chromium.org, nhiroki, pfeldman+blink_chromium.org, rwlbuis, sof, tyoshino+watch_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce unnecessary usage of TextCaseSensitivity::TextCaseInsensitive. Replace TextCaseInsensitive with TextCaseASCIIInsenstive if it looks safe. Typically, comparison with ASCII characters should be TextCaseASCIIInsensitive. This replacement might fix user-visible bugs in some cases, but this CL has no tests because we don't know whether such bugs exist, or how to reproduce such bugs. Also, this CL renames TextCaseInsensitive to TextCaseUnicodeInsensitive. BUG=627682 Committed: https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093 Cr-Commit-Position: refs/heads/master@{#433161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -109 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMImplementation.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/FetchUtils.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/EmailInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp View 2 chunks +71 lines, -61 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp View 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DOMFilePath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFC.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/ContentType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mhtml/MHTMLParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/HTTPParsers.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/network/mime/MIMETypeRegistry.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/text/SegmentedString.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFStringTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (13 generated)
tkent
yutak@, would you review this please?
4 years, 1 month ago (2016-11-18 04:26:39 UTC) #10
Yuta Kitamura
LGTM Thanks for doing this grungy work!
4 years, 1 month ago (2016-11-18 09:32:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508033004/20001
4 years, 1 month ago (2016-11-18 09:37:02 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-11-18 09:43:06 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 09:45:16 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093
Cr-Commit-Position: refs/heads/master@{#433161}

Powered by Google App Engine
This is Rietveld 408576698