third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp - Issue 2508033004: Reduce unnecessary usage of TextCaseSensitivity::TextCaseInsensitive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp

Issue 2508033004: Reduce unnecessary usage of TextCaseSensitivity::TextCaseInsensitive. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp

index 1eeaf072fb28d68c7843f3bfb0abff97d7af5351..3d0ad6c628da510271c735abb08c322112618821 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp

@@ -47,7 +47,7 @@ ScriptRegexp::ScriptRegexp(const String& pattern,

v8::TryCatch tryCatch(isolate);

unsigned flags = v8::RegExp::kNone;

- if (caseSensitivity == TextCaseInsensitive)

+ if (caseSensitivity != TextCaseSensitive)

flags |= v8::RegExp::kIgnoreCase;

if (multilineMode == MultilineEnabled)

flags |= v8::RegExp::kMultiline;