Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4587)

Unified Diff: chrome/browser/managed_mode/managed_mode_interstitial.h

Issue 250803004: Cleanup: Refactor ManagedModeInterstitial to not "delete this" in the ctor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/managed_mode/managed_mode_interstitial.h
diff --git a/chrome/browser/managed_mode/managed_mode_interstitial.h b/chrome/browser/managed_mode/managed_mode_interstitial.h
index 06027d6df424968e0c8374b4df343c10682dfeb1..5a1ead16721a98034f9ede81177a3a1af432a215 100644
--- a/chrome/browser/managed_mode/managed_mode_interstitial.h
+++ b/chrome/browser/managed_mode/managed_mode_interstitial.h
@@ -23,12 +23,19 @@ class WebContents;
// blocked page, to decide later whether to manually allow it.
class ManagedModeInterstitial : public content::InterstitialPageDelegate {
public:
+ virtual ~ManagedModeInterstitial();
Bernhard Bauer 2014/04/25 11:10:18 The destructor doesn't need to be public either. N
Marc Treib 2014/04/25 12:02:19 Done. Good point!
+
+ static void Show(content::WebContents* web_contents,
+ const GURL& url,
+ const base::Callback<void(bool)>& callback);
+
+ private:
ManagedModeInterstitial(content::WebContents* web_contents,
const GURL& url,
const base::Callback<void(bool)>& callback);
- virtual ~ManagedModeInterstitial();
- private:
+ bool Init();
+
// InterstitialPageDelegate implementation.
virtual std::string GetHTMLContents() OVERRIDE;
virtual void CommandReceived(const std::string& command) OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698