Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2508003002: [Sync] Move ChangeProcessor to model/. (Closed)

Created:
4 years, 1 month ago by maxbogue
Modified:
4 years, 1 month ago
Reviewers:
pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Move ChangeProcessor to model/. BUG=631271, 663125 Committed: https://crrev.com/6c9a8fb0c390c21b77340455df70734abaf61342 Cr-Commit-Position: refs/heads/master@{#432938}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -182 lines) Patch
M components/browser_sync/profile_sync_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/browser_sync/profile_sync_service_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
D components/sync/driver/change_processor.h View 1 chunk +0 lines, -72 lines 0 comments Download
D components/sync/driver/change_processor.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D components/sync/driver/change_processor_mock.h View 1 chunk +0 lines, -38 lines 0 comments Download
D components/sync/driver/change_processor_mock.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M components/sync/driver/frontend_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/frontend_data_type_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/generic_change_processor.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/glue/sync_backend_registrar.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/glue/sync_backend_registrar_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/sync_api_component_factory_mock.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/model/change_processor.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/model/change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/model/change_processor_mock.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + components/sync/model/change_processor_mock.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_bookmarks/bookmark_change_processor.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_bookmarks/bookmark_data_type_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
maxbogue
Pavel, PTAL! This is just a file move.
4 years, 1 month ago (2016-11-17 00:31:21 UTC) #4
pavely
lgtm
4 years, 1 month ago (2016-11-17 07:12:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508003002/1
4 years, 1 month ago (2016-11-17 18:12:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 20:09:30 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 20:28:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c9a8fb0c390c21b77340455df70734abaf61342
Cr-Commit-Position: refs/heads/master@{#432938}

Powered by Google App Engine
This is Rietveld 408576698