Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2503423004: [Sync] Move sync's ModelSafeWorker implementations to engine/. (Closed)

Created:
4 years, 1 month ago by maxbogue
Modified:
4 years, 1 month ago
Reviewers:
pavely
CC:
chromium-reviews, mac-reviews_chromium.org, sync-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Move sync's ModelSafeWorker implementations to engine/. PassiveModelWorker already lives in engine/; BrowserThreadModelWorker and UIModelWorker should too. This unblocks moving SyncBackendRegistrar to engine/ as well. BUG=631271, 663125 Committed: https://crrev.com/288c6917ae57645088e0b3346a150be9a2bf5c2c Cr-Commit-Position: refs/heads/master@{#433118}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -414 lines) Patch
M chrome/browser/sync/chrome_sync_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/browser_sync/profile_sync_test_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/BUILD.gn View 1 6 chunks +6 lines, -6 lines 0 comments Download
D components/sync/driver/glue/browser_thread_model_worker.h View 1 chunk +0 lines, -49 lines 0 comments Download
D components/sync/driver/glue/browser_thread_model_worker.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D components/sync/driver/glue/browser_thread_model_worker_unittest.cc View 1 chunk +0 lines, -99 lines 0 comments Download
M components/sync/driver/glue/sync_backend_registrar_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D components/sync/driver/glue/ui_model_worker.h View 1 chunk +0 lines, -40 lines 0 comments Download
D components/sync/driver/glue/ui_model_worker.cc View 1 chunk +0 lines, -71 lines 0 comments Download
D components/sync/driver/glue/ui_model_worker_unittest.cc View 1 chunk +0 lines, -63 lines 0 comments Download
A + components/sync/engine/browser_thread_model_worker.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/engine/browser_thread_model_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/engine/browser_thread_model_worker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/engine/ui_model_worker.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/engine/ui_model_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/engine/ui_model_worker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sync/ios_chrome_sync_client.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
maxbogue
Pavel, PTAL! More mechanical file moves.
4 years, 1 month ago (2016-11-17 00:33:03 UTC) #3
pavely
lgtm
4 years, 1 month ago (2016-11-17 07:08:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503423004/1
4 years, 1 month ago (2016-11-17 21:41:13 UTC) #6
commit-bot: I haz the power
Failed to apply the patch.
4 years, 1 month ago (2016-11-18 00:06:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503423004/20001
4 years, 1 month ago (2016-11-18 01:06:05 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 05:28:47 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 05:32:32 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/288c6917ae57645088e0b3346a150be9a2bf5c2c
Cr-Commit-Position: refs/heads/master@{#433118}

Powered by Google App Engine
This is Rietveld 408576698