Issue 2507933004: Make sure all paths out of the dialog properly unregister observers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2507933004: Make sure all paths out of the dialog properly unregister observers. (Closed)

Created:
4 years, 1 month ago by Avi (use Gerrit)

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2922

Project:
chromium

Visibility:
Public.

Make sure all paths out of the dialog properly unregister observers. BUG=665250, 629964 Review-Url: https://codereview.chromium.org/2505443003 Cr-Commit-Position: refs/heads/master@{#432531} (cherry picked from commit e0c94f8b3e3f6fde6fdfcf85edf69504d06a39d2) Committed: https://chromium.googlesource.com/chromium/src/+/6d1c0bdc6a3011355e69f3688a79b56f9657b7c0

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -1 line)			Patch
	M	chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc	View		4 chunks	+36 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Avi (use Gerrit)

4 years, 1 month ago (2016-11-17 20:11:33 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6d1c0bdc6a3011355e69f3688a79b56f9657b7c0.