Make sure all paths out of the dialog properly unregister observers.

Make sure all paths out of the dialog properly unregister observers.

BUG=665250, 629964
Committed: https://crrev.com/e0c94f8b3e3f6fde6fdfcf85edf69504d06a39d2
Cr-Commit-Position: refs/heads/master@{#432531}

[Avi (use Gerrit), 2016-11-15 22:00:32]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 22:01:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 22:27:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 22:27:18]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Avi (use Gerrit), 2016-11-15 23:28:10]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[Avi (use Gerrit), 2016-11-15 23:28:30]

avi@chromium.org changed reviewers:
+ rsesek@chromium.org

[commit-bot: I haz the power, 2016-11-15 23:28:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 23:49:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 23:49:01]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Avi (use Gerrit), 2016-11-16 15:44:30]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 15:45:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 15:49:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 15:49:41]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-11-16 15:55:06]

avi@chromium.org changed reviewers:
+ pkasting@chromium.org

[Avi (use Gerrit), 2016-11-16 15:55:06]

Robert, Peter:

You were the two main reviewers for the implementations. This is a crash fix
that I want to get into M56 before the branch; if either of you can take a look
that would be appreciated.

[Robert Sesek, 2016-11-16 16:21:51]

LGTM. Is it possible to write a test that triggers the crash (under ASan?)?

[Avi (use Gerrit), 2016-11-16 17:11:07]

On 2016/11/16 16:21:51, Robert Sesek wrote:
> LGTM. Is it possible to write a test that triggers the crash (under ASan?)?

Probably. I have no tests of this functionality at all, though. Let me get this
in and I'll write tests.

[Avi (use Gerrit), 2016-11-16 17:11:11]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-11-16 17:12:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 17:20:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-16 17:48:45]

Description was changed from

==========
Make sure all paths out of the dialog properly unregister observers.

BUG=665250,629964
==========

to

==========
Make sure all paths out of the dialog properly unregister observers.

BUG=665250,629964

Committed: https://crrev.com/e0c94f8b3e3f6fde6fdfcf85edf69504d06a39d2
Cr-Commit-Position: refs/heads/master@{#432531}
==========

[commit-bot: I haz the power, 2016-11-16 17:48:46]

Patchset 1 (id:??) landed as
https://crrev.com/e0c94f8b3e3f6fde6fdfcf85edf69504d06a39d2
Cr-Commit-Position: refs/heads/master@{#432531}