Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2507813002: Fast path for ContentSettingsPattern::Wildcard (Closed)

Created:
4 years, 1 month ago by Charlie Harrison
Modified:
4 years, 1 month ago
Reviewers:
msramek, raymes
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fast path for ContentSettingsPattern::Wildcard This method used to built up a ContentSettingsPattern and validate it using the builder pattern. All this validation work is not needed, and this patch removes it in favor of building the pattern directly. BUG=664174 Committed: https://crrev.com/4eb0252ac0c718fe297a363b57850f7da11c0a40 Cr-Commit-Position: refs/heads/master@{#432506}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M components/content_settings/core/common/content_settings_pattern.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M components/content_settings/core/common/content_settings_pattern_unittest.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
msramek
LGTM, thanks for the optimization! Wildcard() is used a lot inside ContentSettingsPatternTest, so I think ...
4 years, 1 month ago (2016-11-16 15:42:54 UTC) #4
Charlie Harrison
No problem! Thanks for the review.
4 years, 1 month ago (2016-11-16 16:02:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507813002/1
4 years, 1 month ago (2016-11-16 16:03:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 16:10:14 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4eb0252ac0c718fe297a363b57850f7da11c0a40 Cr-Commit-Position: refs/heads/master@{#432506}
4 years, 1 month ago (2016-11-16 16:12:38 UTC) #11
raymes
4 years, 1 month ago (2016-11-16 22:37:57 UTC) #13
Message was sent while issue was closed.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698