Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: components/content_settings/core/common/content_settings_pattern_unittest.cc

Issue 2507813002: Fast path for ContentSettingsPattern::Wildcard (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/content_settings/core/common/content_settings_pattern.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/content_settings/core/common/content_settings_pattern_unittest.cc
diff --git a/components/content_settings/core/common/content_settings_pattern_unittest.cc b/components/content_settings/core/common/content_settings_pattern_unittest.cc
index c24808584454ed3e047b353929a49a76f8249947..d5aab80ab86a3d0d69fde5eef8acd91633b49729 100644
--- a/components/content_settings/core/common/content_settings_pattern_unittest.cc
+++ b/components/content_settings/core/common/content_settings_pattern_unittest.cc
@@ -181,6 +181,17 @@ TEST(ContentSettingsPatternTest, FromURLNoWildcard) {
GURL("filesystem:https://foo.www.google.com/temporary/")));
}
+// The static Wildcard() method goes through a fast path and avoids the Builder
+// pattern. Ensure that it yields the exact same behavior.
+TEST(ContentSettingsPatternTest, ValidWildcardFastPath) {
+ std::unique_ptr<ContentSettingsPattern::BuilderInterface> builder(
+ ContentSettingsPattern::CreateBuilder(true));
+ builder->WithSchemeWildcard()->WithDomainWildcard()->WithPortWildcard()->
+ WithPathWildcard();
+ ContentSettingsPattern built_wildcard = builder->Build();
+ EXPECT_EQ(built_wildcard, ContentSettingsPattern::Wildcard());
+}
+
TEST(ContentSettingsPatternTest, Wildcard) {
EXPECT_TRUE(ContentSettingsPattern::Wildcard().IsValid());
« no previous file with comments | « components/content_settings/core/common/content_settings_pattern.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698