Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1281)

Unified Diff: components/ntp_snippets/content_suggestion.h

Issue 2507793002: [NTP] Propagate OfflineId from C++ for Downloads. (Closed)
Patch Set: rebase. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/content_suggestion.h
diff --git a/components/ntp_snippets/content_suggestion.h b/components/ntp_snippets/content_suggestion.h
index 630b7e5ad65efe1740c13d78cd0807a3dea7a7d5..b6f0e4b2d7a4ae8b7fce6af02d60afc537c348fe 100644
--- a/components/ntp_snippets/content_suggestion.h
+++ b/components/ntp_snippets/content_suggestion.h
@@ -20,11 +20,18 @@ namespace ntp_snippets {
// DownloadSuggestionExtra contains additional data which is only available for
// download suggestions.
struct DownloadSuggestionExtra {
+ DownloadSuggestionExtra();
+ ~DownloadSuggestionExtra();
+
// The file path of the downloaded file once download completes.
base::FilePath target_file_path;
// The effective MIME type of downloaded content.
std::string mime_type;
+ // Underlying offline page identifier.
+ int64_t offline_page_id = 0;
// Whether or not the download suggestion is a downloaded asset.
+ // When this is true, |offline_page_id| is ignored, otherwise
+ // |target_file_path| and |mime_type| are ignored.
bool is_download_asset = false;
};
@@ -33,7 +40,7 @@ struct RecentTabSuggestionExtra {
// Corresponding tab identifier.
std::string tab_id;
// Underlying offline page identifier.
- std::string offline_page_id;
+ int64_t offline_page_id;
};
// A content suggestion for the new tab page, which can be an article or an
« no previous file with comments | « chrome/browser/ntp_snippets/download_suggestions_provider.cc ('k') | components/ntp_snippets/content_suggestion.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698