chrome/browser/ntp_snippets/download_suggestions_provider.cc - Issue 2507793002: [NTP] Propagate OfflineId from C++ for Downloads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ntp_snippets/download_suggestions_provider.cc

Issue 2507793002: [NTP] Propagate OfflineId from C++ for Downloads. (Closed)

Patch Set: rebase. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ntp_snippets/download_suggestions_provider.cc

diff --git a/chrome/browser/ntp_snippets/download_suggestions_provider.cc b/chrome/browser/ntp_snippets/download_suggestions_provider.cc

index c5ef7dda97185091978abecbf1b093c809bb452e..2c1393158dd627bd903dda2eaa4afd0a8180b4ca 100644

--- a/chrome/browser/ntp_snippets/download_suggestions_provider.cc

+++ b/chrome/browser/ntp_snippets/download_suggestions_provider.cc

@@ -488,6 +488,7 @@ ContentSuggestion DownloadSuggestionsProvider::ConvertOfflinePage(

suggestion.set_publisher_name(base::UTF8ToUTF16(offline_page.url.host()));

auto extra = base::MakeUnique<ntp_snippets::DownloadSuggestionExtra>();

extra->is_download_asset = false;

+ extra->offline_page_id = offline_page.offline_id;

suggestion.set_download_suggestion_extra(std::move(extra));

return suggestion;

}