Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

Issue 2507793002: [NTP] Propagate OfflineId from C++ for Downloads. (Closed)
Patch Set: rebase. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
index 9658d36b5f3f0ac5def4b5ea479014e94f2f31ef..28882cbd6e1dc66d8b9ec672bc2c006092649ff2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
@@ -209,6 +209,8 @@ public class SnippetsBridge implements SuggestionsSource {
timestamp, score, position, cardLayout));
}
+ // TODO(vitaliii): Remove all |.*ForLastSuggestion| methods and instead make |addSuggestion|
+ // return the suggestion and set the values there.
@CalledByNative
private static void setDownloadAssetDataForLastSuggestion(
List<SnippetArticle> suggestions, String filePath, String mimeType) {
@@ -217,8 +219,15 @@ public class SnippetsBridge implements SuggestionsSource {
}
@CalledByNative
+ private static void setDownloadOfflinePageDataForLastSuggestion(
+ List<SnippetArticle> suggestions, long offlinePageId) {
+ assert suggestions.size() > 0;
+ suggestions.get(suggestions.size() - 1).setDownloadOfflinePageData(offlinePageId);
+ }
+
+ @CalledByNative
private static void setRecentTabDataForLastSuggestion(
- List<SnippetArticle> suggestions, String tabId, String offlinePageId) {
+ List<SnippetArticle> suggestions, String tabId, long offlinePageId) {
assert suggestions.size() > 0;
suggestions.get(suggestions.size() - 1).setRecentTabData(tabId, offlinePageId);
}

Powered by Google App Engine
This is Rietveld 408576698