Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4254)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java

Issue 2507793002: [NTP] Propagate OfflineId from C++ for Downloads. (Closed)
Patch Set: rebase. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
index 7d8480750bfe76759495ffecba6847c016cda3ad..2008f8492e0a1c4524d0c639f21fab7487b44a7b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
@@ -75,9 +75,6 @@ public class SnippetArticle {
/** The tab id of the corresponding tab (only for recent tab articles). */
private String mRecentTabId;
- /** The offline page id (only for recent tab articles). */
- private String mRecentTabOfflinePageId;
-
/** The offline id of the corresponding offline page, if any. */
private Long mOfflinePageOfflineId;
@@ -177,9 +174,19 @@ public class SnippetArticle {
}
/**
- * @return whether a snippet has to be matched with the exact offline page or with the most
- * recent offline page found by the snippet's URL.
+ * Marks the article suggestion as a download offline page with the given id. May only be called
+ * if this snippet belongs to DOWNLOADS category.
*/
+ public void setDownloadOfflinePageData(long offlinePageId) {
+ assert isDownload();
+ mIsDownloadedAsset = false;
+ setOfflinePageOfflineId(offlinePageId);
+ }
+
+ /**
+ * @return whether a snippet has to be matched with the exact offline page or with the most
+ * recent offline page found by the snippet's URL.
+ */
public boolean requiresExactOfflinePage() {
return isDownload() || isRecentTab();
}
@@ -198,22 +205,13 @@ public class SnippetArticle {
}
/**
- * @return the corresponding recent tab offline page id. May only be called if this snippet is a
- * recent tab article.
- */
- public String getRecentTabOfflinePageId() {
- assert isRecentTab();
- return mRecentTabOfflinePageId;
- }
-
- /**
* Sets tab id and offline page id for recent tab articles. May only be called if this snippet
* is a recent tab article.
*/
- public void setRecentTabData(String tabId, String offlinePageId) {
+ public void setRecentTabData(String tabId, long offlinePageId) {
assert isRecentTab();
mRecentTabId = tabId;
- mRecentTabOfflinePageId = offlinePageId;
+ setOfflinePageOfflineId(offlinePageId);
}
/** Sets offline id of the corresponding to the snippet offline page. Null to clear.*/

Powered by Google App Engine
This is Rietveld 408576698