Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2507783002: Correctly initialize m_hasDataChannels field in RTCPeerConnection (Closed)

Created:
4 years, 1 month ago by Guido Urdaneta
Modified:
4 years, 1 month ago
Reviewers:
hbos_chromium
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly initialize m_hasDataChannels field in RTCPeerConnection BUG=665884 Committed: https://crrev.com/81bc06645eda2bc80ac82983824418b6dab9dcec Cr-Commit-Position: refs/heads/master@{#432514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
hbos_chromium
lgtm
4 years, 1 month ago (2016-11-16 14:15:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507783002/1
4 years, 1 month ago (2016-11-16 16:21:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 16:35:58 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 16:41:14 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81bc06645eda2bc80ac82983824418b6dab9dcec
Cr-Commit-Position: refs/heads/master@{#432514}

Powered by Google App Engine
This is Rietveld 408576698