Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1512)

Side by Side Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

Issue 2507783002: Correctly initialize m_hasDataChannels field in RTCPeerConnection (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 476 matching lines...) Expand 10 before | Expand all | Expand 10 after
487 : ActiveScriptWrappable(this), 487 : ActiveScriptWrappable(this),
488 ActiveDOMObject(context), 488 ActiveDOMObject(context),
489 m_signalingState(SignalingStateStable), 489 m_signalingState(SignalingStateStable),
490 m_iceGatheringState(ICEGatheringStateNew), 490 m_iceGatheringState(ICEGatheringStateNew),
491 m_iceConnectionState(ICEConnectionStateNew), 491 m_iceConnectionState(ICEConnectionStateNew),
492 m_dispatchScheduledEventRunner( 492 m_dispatchScheduledEventRunner(
493 AsyncMethodRunner<RTCPeerConnection>::create( 493 AsyncMethodRunner<RTCPeerConnection>::create(
494 this, 494 this,
495 &RTCPeerConnection::dispatchScheduledEvent)), 495 &RTCPeerConnection::dispatchScheduledEvent)),
496 m_stopped(false), 496 m_stopped(false),
497 m_closed(false) { 497 m_closed(false),
498 m_hasDataChannels(false) {
498 ThreadState::current()->registerPreFinalizer(this); 499 ThreadState::current()->registerPreFinalizer(this);
499 Document* document = toDocument(getExecutionContext()); 500 Document* document = toDocument(getExecutionContext());
500 501
501 // If we fail, set |m_closed| and |m_stopped| to true, to avoid hitting the 502 // If we fail, set |m_closed| and |m_stopped| to true, to avoid hitting the
502 // assert in the destructor. 503 // assert in the destructor.
503 504
504 if (!document->frame()) { 505 if (!document->frame()) {
505 m_closed = true; 506 m_closed = true;
506 m_stopped = true; 507 m_stopped = true;
507 exceptionState.throwDOMException( 508 exceptionState.throwDOMException(
(...skipping 971 matching lines...) Expand 10 before | Expand all | Expand 10 after
1479 DEFINE_TRACE(RTCPeerConnection) { 1480 DEFINE_TRACE(RTCPeerConnection) {
1480 visitor->trace(m_localStreams); 1481 visitor->trace(m_localStreams);
1481 visitor->trace(m_remoteStreams); 1482 visitor->trace(m_remoteStreams);
1482 visitor->trace(m_dispatchScheduledEventRunner); 1483 visitor->trace(m_dispatchScheduledEventRunner);
1483 visitor->trace(m_scheduledEvents); 1484 visitor->trace(m_scheduledEvents);
1484 EventTargetWithInlineData::trace(visitor); 1485 EventTargetWithInlineData::trace(visitor);
1485 ActiveDOMObject::trace(visitor); 1486 ActiveDOMObject::trace(visitor);
1486 } 1487 }
1487 1488
1488 } // namespace blink 1489 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698