[refactoring] Pull AccessorAssembler out of CodeStubAssembler

[refactoring] Pull AccessorAssembler out of CodeStubAssembler

The new AccessorAssembler encapsulates all the functionality that's
specific to building LoadIC/StoreIC stubs.
There are two header files (accessor-assembler.h and
accessor-assembler-impl.h) so that clients of the assembler can include
the one, and subclassing assemblers can include the other.

Committed: https://crrev.com/248a3e25e9e92c985c48fd93f9c232a2a2822b0a
Cr-Commit-Position: refs/heads/master@{#41037}

[Jakob Kummerow, 2016-11-16 13:30:32]

jkummerow@chromium.org changed reviewers:
+ ishell@chromium.org

[Jakob Kummerow, 2016-11-16 13:30:33]

Just shuffling code around, no change in functionality intended. Please take a
look.

https://codereview.chromium.org/2507733002/diff/1/src/ic/accessor-assembler.cc
File src/ic/accessor-assembler.cc (right):

https://codereview.chromium.org/2507733002/diff/1/src/ic/accessor-assembler.c...
src/ic/accessor-assembler.cc:1687: //////////////////// AccessorAssembler
implementation.
Everything below is the only part of this file that's not cut-and-pasted from
elsewhere.

https://codereview.chromium.org/2507733002/diff/1/src/ic/keyed-store-generic.cc
File src/ic/keyed-store-generic.cc (right):

https://codereview.chromium.org/2507733002/diff/1/src/ic/keyed-store-generic....
src/ic/keyed-store-generic.cc:96: GotoIf(IsFastElementsKind(elements_kind),
&loop_body);
Drive-by cleanup :-)

[Igor Sheludko, 2016-11-16 13:56:16]

Good start! lgtm

https://codereview.chromium.org/2507733002/diff/1/src/ic/accessor-assembler.cc
File src/ic/accessor-assembler.cc (right):

https://codereview.chromium.org/2507733002/diff/1/src/ic/accessor-assembler.c...
src/ic/accessor-assembler.cc:1591: void
AccessorAssemblerImpl::GenerateKeyedLoadICTF() {
Let's drop the TF suffixes in a follow-up CL :)

https://codereview.chromium.org/2507733002/diff/1/src/ic/accessor-assembler.c...
src/ic/accessor-assembler.cc:1687: //////////////////// AccessorAssembler
implementation.
On 2016/11/16 13:30:33, Jakob Kummerow wrote:
> Everything below is the only part of this file that's not cut-and-pasted from
> elsewhere.

Acknowledged.

https://codereview.chromium.org/2507733002/diff/1/src/ic/keyed-store-generic.cc
File src/ic/keyed-store-generic.cc (right):

https://codereview.chromium.org/2507733002/diff/1/src/ic/keyed-store-generic....
src/ic/keyed-store-generic.cc:96: GotoIf(IsFastElementsKind(elements_kind),
&loop_body);
On 2016/11/16 13:30:33, Jakob Kummerow wrote:
> Drive-by cleanup :-)

Acknowledged.

[Jakob Kummerow, 2016-11-16 13:59:20]

The CQ bit was checked by jkummerow@chromium.org

[commit-bot: I haz the power, 2016-11-16 13:59:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 14:25:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-17 22:36:23]

Description was changed from

==========
[refactoring] Pull AccessorAssembler out of CodeStubAssembler

The new AccessorAssembler encapsulates all the functionality that's
specific to building LoadIC/StoreIC stubs.
There are two header files (accessor-assembler.h and
accessor-assembler-impl.h) so that clients of the assembler can include
the one, and subclassing assemblers can include the other.
==========

to

==========
[refactoring] Pull AccessorAssembler out of CodeStubAssembler

The new AccessorAssembler encapsulates all the functionality that's
specific to building LoadIC/StoreIC stubs.
There are two header files (accessor-assembler.h and
accessor-assembler-impl.h) so that clients of the assembler can include
the one, and subclassing assemblers can include the other.

Committed: https://crrev.com/248a3e25e9e92c985c48fd93f9c232a2a2822b0a
Cr-Commit-Position: refs/heads/master@{#41037}
==========

[commit-bot: I haz the power, 2016-11-17 22:36:24]

Patchset 1 (id:??) landed as
https://crrev.com/248a3e25e9e92c985c48fd93f9c232a2a2822b0a
Cr-Commit-Position: refs/heads/master@{#41037}