Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 250773005: Adding mojo_test_apk in the fyi waterfall. (Closed)

Created:
6 years, 8 months ago by qsr
Modified:
6 years, 7 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Adding mojo_test_apk to build. #

Patch Set 3 : Fixing java compilation -> compiler in the bot seems less lenient that mine. #

Patch Set 4 : Fix pair #

Patch Set 5 : FIx lint warning #

Patch Set 6 : Fix findbugs warnings #

Patch Set 7 : Remving is_test_apk as this is useful for instrumentation test that instrument another apk. #

Patch Set 8 : Fix visibility #

Patch Set 9 : Fix instrumentation issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -24 lines) Patch
M build/all.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/buildbot/bb_device_steps.py View 4 chunks +21 lines, -4 lines 0 comments Download
M build/android/buildbot/bb_run_bot.py View 2 chunks +2 lines, -1 line 0 comments Download
M build/java_apk.gypi View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -5 lines 0 comments Download
M mojo/android/system/src/org/chromium/mojo/system/CoreImpl.java View 1 2 3 4 5 6 7 3 chunks +7 lines, -11 lines 0 comments Download
M mojo/mojo.gyp View 1 2 3 4 5 6 7 8 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/public/java/src/org/chromium/mojo/system/Pair.java View 1 2 3 4 5 4 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 25 (0 generated)
qsr
Is there any way to test this change? Will a try bot read those files ...
6 years, 8 months ago (2014-04-25 14:29:17 UTC) #1
qsr
Found out the mojo test apk was not build, so added it, and fix some ...
6 years, 7 months ago (2014-04-28 11:40:15 UTC) #2
viettrungluu
mojo owners lgtm
6 years, 7 months ago (2014-04-28 15:00:47 UTC) #3
qsr
+frankf as Armand seems to be OoO at the moment.
6 years, 7 months ago (2014-04-29 12:42:09 UTC) #4
klundberg
On 2014/04/29 12:42:09, qsr wrote: > +frankf as Armand seems to be OoO at the ...
6 years, 7 months ago (2014-04-29 16:05:16 UTC) #5
qsr
> FYI, Frank is no longer on the team but Armand is around. You might ...
6 years, 7 months ago (2014-04-29 16:08:55 UTC) #6
navabi
lgtm from infra side of things. Please locally make sure everything still builds correctly with ...
6 years, 7 months ago (2014-04-29 18:50:17 UTC) #7
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 7 months ago (2014-04-30 07:49:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/250773005/130001
6 years, 7 months ago (2014-04-30 07:49:49 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 07:53:07 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clang_dbg on tryserver.chromium
6 years, 7 months ago (2014-04-30 07:53:07 UTC) #11
qsr
Armand -> You need to LGTM this with your chromium account for owner.
6 years, 7 months ago (2014-04-30 08:14:24 UTC) #12
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 7 months ago (2014-04-30 08:14:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/250773005/130001
6 years, 7 months ago (2014-04-30 08:14:54 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 08:17:44 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 08:17:44 UTC) #16
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 7 months ago (2014-04-30 08:19:53 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/250773005/130001
6 years, 7 months ago (2014-04-30 08:20:08 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 08:23:10 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 08:23:10 UTC) #20
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 7 months ago (2014-04-30 10:35:23 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/250773005/130001
6 years, 7 months ago (2014-04-30 10:36:03 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 10:38:24 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 10:38:25 UTC) #24
qsr
6 years, 7 months ago (2014-04-30 11:22:53 UTC) #25
Message was sent while issue was closed.
Committed patchset #9 manually as r267180 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698