Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2804)

Unified Diff: build/android/buildbot/bb_device_steps.py

Issue 250773005: Adding mojo_test_apk in the fyi waterfall. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix instrumentation issue. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/all.gyp ('k') | build/android/buildbot/bb_run_bot.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/bb_device_steps.py
diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py
index 47842b2f5ed9f34790aec7262bd193702f736957..dc2212b2298ddb68a8cb00d35fb8950600af3419 100755
--- a/build/android/buildbot/bb_device_steps.py
+++ b/build/android/buildbot/bb_device_steps.py
@@ -79,7 +79,7 @@ INSTRUMENTATION_TESTS = dict((suite.name, suite) for suite in [
'webview:android_webview/test/data/device_files'),
])
-VALID_TESTS = set(['chromedriver', 'gpu', 'telemetry_perf_unittests',
+VALID_TESTS = set(['chromedriver', 'gpu', 'mojo', 'telemetry_perf_unittests',
'ui', 'unit', 'webkit', 'webkit_layout', 'webrtc_chromium',
'webrtc_native'])
@@ -182,6 +182,20 @@ def RunTelemetryPerfUnitTests(options):
RunCmd(['tools/perf/run_tests'] + args)
+def RunMojoTests(options):
+ """Runs the mojo unit tests.
+
+ Args:
+ options: options object.
+ """
+ test = I('MojoTest',
+ None,
+ 'org.chromium.mojo.tests',
+ 'MojoTest',
+ None)
+ RunInstrumentationSuite(options, test)
+
+
def InstallApk(options, test, print_step=False):
"""Install an apk to all phones.
@@ -213,9 +227,11 @@ def RunInstrumentationSuite(options, test, flunk_on_failure=True,
"""
bb_annotations.PrintNamedStep('%s_instrumentation_tests' % test.name.lower())
- InstallApk(options, test)
- args = ['--test-apk', test.test_apk, '--test_data', test.test_data,
- '--verbose']
+ if test.apk:
+ InstallApk(options, test)
+ args = ['--test-apk', test.test_apk, '--verbose']
+ if test.test_data:
+ args.extend(['--test_data', test.test_data])
if options.target == 'Release':
args.append('--release')
if options.asan:
@@ -498,6 +514,7 @@ def GetTestStepCmds():
return [
('chromedriver', RunChromeDriverTests),
('gpu', RunGPUTests),
+ ('mojo', RunMojoTests),
('telemetry_perf_unittests', RunTelemetryPerfUnitTests),
('unit', RunUnitTests),
('ui', RunInstrumentationTests),
« no previous file with comments | « build/all.gyp ('k') | build/android/buildbot/bb_run_bot.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698