Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h

Issue 2507673002: Scheduler: Deprecate CancellableTaskFactory in favor of WebTaskRunner::postCancellableTask (2) (Closed)
Patch Set: address review comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h
diff --git a/third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h b/third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h
index ba97583fcb8d65f0af5c19447fb222ca2506a781..c278799fa45b7f4f83c549e7b3bd6faee0674156 100644
--- a/third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h
+++ b/third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h
@@ -27,7 +27,7 @@
#define HTMLParserScheduler_h
#include "core/html/parser/NestingLevelIncrementer.h"
-#include "platform/scheduler/CancellableTaskFactory.h"
+#include "platform/WebTaskRunner.h"
#include "wtf/Allocator.h"
#include "wtf/RefPtr.h"
#include <memory>
@@ -72,11 +72,7 @@ class HTMLParserScheduler final
}
~HTMLParserScheduler();
- bool isScheduledForResume() const {
- return m_isSuspendedWithActiveTimer ||
- m_cancellableContinueParse->isPending();
- }
-
+ bool isScheduledForResume() const;
void scheduleForResume();
bool yieldIfNeeded(const SpeculationsPumpSession&, bool startingScript);
@@ -105,7 +101,7 @@ class HTMLParserScheduler final
Member<HTMLDocumentParser> m_parser;
std::unique_ptr<WebTaskRunner> m_loadingTaskRunner;
- std::unique_ptr<CancellableTaskFactory> m_cancellableContinueParse;
+ TaskHandle m_cancellableContinueParseTaskHandle;
bool m_isSuspendedWithActiveTimer;
};

Powered by Google App Engine
This is Rietveld 408576698