Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h

Issue 2507673002: Scheduler: Deprecate CancellableTaskFactory in favor of WebTaskRunner::postCancellableTask (2) (Closed)
Patch Set: address review comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google, Inc. All Rights Reserved. 2 * Copyright (C) 2010 Google, Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef HTMLParserScheduler_h 26 #ifndef HTMLParserScheduler_h
27 #define HTMLParserScheduler_h 27 #define HTMLParserScheduler_h
28 28
29 #include "core/html/parser/NestingLevelIncrementer.h" 29 #include "core/html/parser/NestingLevelIncrementer.h"
30 #include "platform/scheduler/CancellableTaskFactory.h" 30 #include "platform/WebTaskRunner.h"
31 #include "wtf/Allocator.h" 31 #include "wtf/Allocator.h"
32 #include "wtf/RefPtr.h" 32 #include "wtf/RefPtr.h"
33 #include <memory> 33 #include <memory>
34 34
35 namespace blink { 35 namespace blink {
36 36
37 class HTMLDocumentParser; 37 class HTMLDocumentParser;
38 class WebTaskRunner; 38 class WebTaskRunner;
39 39
40 class PumpSession : public NestingLevelIncrementer { 40 class PumpSession : public NestingLevelIncrementer {
(...skipping 24 matching lines...) Expand all
65 : public GarbageCollectedFinalized<HTMLParserScheduler> { 65 : public GarbageCollectedFinalized<HTMLParserScheduler> {
66 WTF_MAKE_NONCOPYABLE(HTMLParserScheduler); 66 WTF_MAKE_NONCOPYABLE(HTMLParserScheduler);
67 67
68 public: 68 public:
69 static HTMLParserScheduler* create(HTMLDocumentParser* parser, 69 static HTMLParserScheduler* create(HTMLDocumentParser* parser,
70 WebTaskRunner* loadingTaskRunner) { 70 WebTaskRunner* loadingTaskRunner) {
71 return new HTMLParserScheduler(parser, loadingTaskRunner); 71 return new HTMLParserScheduler(parser, loadingTaskRunner);
72 } 72 }
73 ~HTMLParserScheduler(); 73 ~HTMLParserScheduler();
74 74
75 bool isScheduledForResume() const { 75 bool isScheduledForResume() const;
76 return m_isSuspendedWithActiveTimer ||
77 m_cancellableContinueParse->isPending();
78 }
79
80 void scheduleForResume(); 76 void scheduleForResume();
81 bool yieldIfNeeded(const SpeculationsPumpSession&, bool startingScript); 77 bool yieldIfNeeded(const SpeculationsPumpSession&, bool startingScript);
82 78
83 /** 79 /**
84 * Can only be called if this scheduler is suspended. If this is called, 80 * Can only be called if this scheduler is suspended. If this is called,
85 * then after the scheduler is resumed by calling resume(), this call 81 * then after the scheduler is resumed by calling resume(), this call
86 * ensures that HTMLDocumentParser::resumeAfterYield will be called. Used to 82 * ensures that HTMLDocumentParser::resumeAfterYield will be called. Used to
87 * signal this scheduler that the background html parser sent chunks to 83 * signal this scheduler that the background html parser sent chunks to
88 * HTMLDocumentParser while it was suspended. 84 * HTMLDocumentParser while it was suspended.
89 */ 85 */
90 void forceResumeAfterYield(); 86 void forceResumeAfterYield();
91 87
92 void suspend(); 88 void suspend();
93 void resume(); 89 void resume();
94 90
95 void detach(); // Clear active tasks if any. 91 void detach(); // Clear active tasks if any.
96 92
97 DECLARE_TRACE(); 93 DECLARE_TRACE();
98 94
99 private: 95 private:
100 HTMLParserScheduler(HTMLDocumentParser*, WebTaskRunner*); 96 HTMLParserScheduler(HTMLDocumentParser*, WebTaskRunner*);
101 97
102 bool shouldYield(const SpeculationsPumpSession&, bool startingScript) const; 98 bool shouldYield(const SpeculationsPumpSession&, bool startingScript) const;
103 void continueParsing(); 99 void continueParsing();
104 100
105 Member<HTMLDocumentParser> m_parser; 101 Member<HTMLDocumentParser> m_parser;
106 std::unique_ptr<WebTaskRunner> m_loadingTaskRunner; 102 std::unique_ptr<WebTaskRunner> m_loadingTaskRunner;
107 103
108 std::unique_ptr<CancellableTaskFactory> m_cancellableContinueParse; 104 TaskHandle m_cancellableContinueParseTaskHandle;
109 bool m_isSuspendedWithActiveTimer; 105 bool m_isSuspendedWithActiveTimer;
110 }; 106 };
111 107
112 } // namespace blink 108 } // namespace blink
113 109
114 #endif 110 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698