Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2507663003: [ic] Enable interceptor handlers for LoadGlobalIC. (Closed)

Created:
4 years, 1 month ago by Igor Sheludko
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Enable interceptor handlers for LoadGlobalIC. BUG=chromium:576312, v8:5561 Committed: https://crrev.com/32793ab33f34f4459bbbb9394566c6a5b78c8095 Cr-Commit-Position: refs/heads/master@{#41054}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -19 lines) Patch
M src/ic/ic.cc View 2 chunks +14 lines, -19 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
Igor Sheludko
PTAL
4 years, 1 month ago (2016-11-16 11:49:57 UTC) #4
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-11-16 13:57:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507663003/1
4 years, 1 month ago (2016-11-16 20:32:14 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 21:04:40 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:37:15 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32793ab33f34f4459bbbb9394566c6a5b78c8095
Cr-Commit-Position: refs/heads/master@{#41054}

Powered by Google App Engine
This is Rietveld 408576698