Improve noSuchMethod error message for type objects.

Improve noSuchMethod error message for type objects.

This CL improves the message when trying to invoke 'call' on _Type objects. This often happens
when 'new' is forgotten ("C()" instead of "new C()")

Fixes #27651.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/2a40a14c7a30be936645aaabc1cd5d65ae19fb5b

[Florian Schneider, 2016-11-15 21:50:19]

fschneider@google.com changed reviewers:
+ rmacnak@google.com

[Florian Schneider, 2016-11-15 21:50:20]

The new message looks like this:

NoSuchMethodError: Attempted to use type 'A' as a function. Since types do not
define a method 'call', this is not possible. Did you intend to call the A
constructor and forget the 'new' operator?
Receiver: Type: class 'A'
Tried calling: A(1, 2, 4)

[Hixie, 2016-11-15 21:56:12]

I think this is an improvement and I love it.

For the record, the reason I didn't do this when I was changing the method a few
weeks ago is that it will give the wrong message for cases like:

   int.call(1);

...where you explicitly call "call" on a type.

But it's probably still worth it because that's going to much rarer than
omitting "new"...

[Florian Schneider, 2016-11-15 22:46:45]

On 2016/11/15 21:56:12, Hixie wrote:
> I think this is an improvement and I love it.
> 
> For the record, the reason I didn't do this when I was changing the method a
few
> weeks ago is that it will give the wrong message for cases like:
> 
>    int.call(1);
> 
> ...where you explicitly call "call" on a type.
> 
> But it's probably still worth it because that's going to much rarer than
> omitting "new"...

Correct. I don't know of a way to distinguish explicit invocation of .call from
implicit using the () operator, so the hint about forgetting 'new' will be out
of place for this (probably rare) case T.call().

[rmacnak, 2016-11-15 22:52:05]

lgtm

[Florian Schneider, 2016-11-15 23:20:21]

Description was changed from

==========
Improve noSuchMethod error message for type objects.

This CL improves the message when trying to invoke 'call' on _Type objects. This
often happens
when 'new' is forgotten ("C()" instead of "new C()")

Fixes #27651.
==========

to

==========
Improve noSuchMethod error message for type objects.

This CL improves the message when trying to invoke 'call' on _Type objects. This
often happens
when 'new' is forgotten ("C()" instead of "new C()")

Fixes #27651.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2a40a14c7a30be936645aaabc1cd5d65ae19fb5b
==========

[Florian Schneider, 2016-11-15 23:20:23]

Committed patchset #2 (id:20001) manually as
2a40a14c7a30be936645aaabc1cd5d65ae19fb5b (presubmit successful).