Issue 250733003: Revert 266159 "Adds more to viewmanager"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 250733003: Revert 266159 "Adds more to viewmanager" (Closed)

Created:
6 years, 8 months ago by yosin_UTC9

Modified:
6 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 266159 "Adds more to viewmanager" Compilation error: c:\b\build\slave\cr-win-rel-x64\build\src\mojo\services\view_manager\view_manager_connection.cc(199) : error C2723: 'mojo::services::view_manager::ViewManagerConnection::DeleteView' : 'override' specifier illegal on function definition http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder/builds/17746/steps/compile/logs/stdio > Adds more to viewmanager > > Specifically ability to delete nodes, create views and attach them. > > BUG=365012 > TEST=covered by tests > R=ben@chromium.org > > Review URL: https://codereview.chromium.org/250633003 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266162

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -596 lines)			Patch
M	trunk/src/mojo/examples/sample_view_manager_app/sample_view_manager_app.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	trunk/src/mojo/mojo_services.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/mojo/services/public/interfaces/view_manager/view_manager.mojom	View	3 chunks	+2 lines, -16 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/ids.h	View	3 chunks	+0 lines, -12 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/node.h	View	4 chunks	+0 lines, -14 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/node.cc	View	4 chunks	+0 lines, -33 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/node_delegate.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/root_node_manager.h	View	2 chunks	+1 line, -14 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/root_node_manager.cc	View	4 chunks	+0 lines, -29 lines	0 comments	Download
D	trunk/src/mojo/services/view_manager/view.h	View	1 chunk	+0 lines, -46 lines	0 comments	Download
D	trunk/src/mojo/services/view_manager/view.cc	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/view_manager_connection.h	View	4 chunks	+1 line, -44 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/view_manager_connection.cc	View	6 chunks	+0 lines, -130 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/view_manager_connection_unittest.cc	View	8 chunks	+6 lines, -225 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

yosin_UTC9

6 years, 8 months ago (2014-04-25 08:52:58 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r266162 (tree was closed).

Expand Messages | Collapse Messages