Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 250633003: Adds more to viewmanager (Closed)

Created:
6 years, 8 months ago by sky
Modified:
6 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Adds more to viewmanager Specifically ability to delete nodes, create views and attach them. BUG=365012 TEST=covered by tests R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266159 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266190

Patch Set 1 #

Total comments: 2

Patch Set 2 : change->replaced #

Patch Set 3 : dont include messagepump fix #

Patch Set 4 : revert synced to master #

Patch Set 5 : override #

Unified diffs Side-by-side diffs Delta from patch set Stats (+581 lines, -15 lines) Patch
M mojo/examples/sample_view_manager_app/sample_view_manager_app.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/mojo_services.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 1 3 chunks +16 lines, -2 lines 0 comments Download
M mojo/services/view_manager/ids.h View 3 chunks +12 lines, -0 lines 0 comments Download
M mojo/services/view_manager/node.h View 4 chunks +14 lines, -0 lines 0 comments Download
M mojo/services/view_manager/node.cc View 1 4 chunks +33 lines, -0 lines 0 comments Download
M mojo/services/view_manager/node_delegate.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.h View 1 2 chunks +14 lines, -1 line 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 1 4 chunks +29 lines, -0 lines 0 comments Download
A mojo/services/view_manager/view.h View 1 chunk +46 lines, -0 lines 0 comments Download
A + mojo/services/view_manager/view.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.h View 1 2 3 4 4 chunks +44 lines, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_connection.cc View 1 2 3 4 6 chunks +130 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection_unittest.cc View 1 8 chunks +225 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
sky
6 years, 8 months ago (2014-04-24 18:07:06 UTC) #1
Ben Goodger (Google)
lgtm https://codereview.chromium.org/250633003/diff/1/mojo/services/public/interfaces/view_manager/view_manager.mojom File mojo/services/public/interfaces/view_manager/view_manager.mojom (right): https://codereview.chromium.org/250633003/diff/1/mojo/services/public/interfaces/view_manager/view_manager.mojom#newcode62 mojo/services/public/interfaces/view_manager/view_manager.mojom:62: OnNodeViewChanged(uint32 node, Maybe you want to call this ...
6 years, 8 months ago (2014-04-24 18:22:42 UTC) #2
sky
https://codereview.chromium.org/250633003/diff/1/mojo/services/public/interfaces/view_manager/view_manager.mojom File mojo/services/public/interfaces/view_manager/view_manager.mojom (right): https://codereview.chromium.org/250633003/diff/1/mojo/services/public/interfaces/view_manager/view_manager.mojom#newcode62 mojo/services/public/interfaces/view_manager/view_manager.mojom:62: OnNodeViewChanged(uint32 node, On 2014/04/24 18:22:42, Ben Goodger (Google) wrote: ...
6 years, 8 months ago (2014-04-24 19:04:12 UTC) #3
sky
The CQ bit was checked by sky@chromium.org
6 years, 8 months ago (2014-04-24 19:06:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/250633003/30001
6 years, 8 months ago (2014-04-24 21:49:28 UTC) #5
commit-bot: I haz the power
Change committed as 266159
6 years, 8 months ago (2014-04-25 08:37:19 UTC) #6
sky
This was reverted because of OVERRIDE errors. I've fixed them (diff between 4 and 5 ...
6 years, 8 months ago (2014-04-25 14:26:57 UTC) #7
sky
6 years, 8 months ago (2014-04-25 15:11:19 UTC) #8
Message was sent while issue was closed. 
Committed patchset #5 manually as r266190 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698