Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2683)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java

Issue 2507173002: 📰 Cleanup ContextMenuManager and add tests (Closed)
Patch Set: address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java
index 92a82731e9475b68cc50421764ca1e2393569c6e..59b9ad79ff1ac883df421e12675cc029365a056a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java
@@ -13,14 +13,12 @@
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ntp.ContextMenuManager;
+import org.chromium.chrome.browser.ntp.ContextMenuManager.ContextMenuItemId;
import org.chromium.chrome.browser.ntp.ContextMenuManager.Delegate;
import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
import org.chromium.chrome.browser.ntp.UiConfig;
import org.chromium.chrome.browser.ntp.snippets.SnippetsConfig;
-import java.util.HashSet;
-import java.util.Set;
-
/**
* ViewHolder for Status and Promo cards.
*/
@@ -110,14 +108,8 @@ public String getUrl() {
}
@Override
- public Set<Integer> getSupportedMenuItems() {
- Set<Integer> supportedItems = new HashSet<>();
-
- if (SnippetsConfig.isSectionDismissalEnabled()) {
- supportedItems.add(ContextMenuManager.ID_REMOVE);
- }
-
- return supportedItems;
+ public boolean isItemSupported(@ContextMenuItemId int menuItemId) {
+ return menuItemId == ContextMenuManager.ID_REMOVE && isDismissable();
}
@Override

Powered by Google App Engine
This is Rietveld 408576698