Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4948)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

Issue 2507173002: 📰 Cleanup ContextMenuManager and add tests (Closed)
Patch Set: address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
index 251ea9d1ecdbac594c6846fc0dd2d21270117bc3..4e6943b6cd0d8aaa0b81eda643b04dc38d520fcf 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
@@ -10,6 +10,7 @@
import org.chromium.base.VisibleForTesting;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ntp.ContextMenuManager;
+import org.chromium.chrome.browser.ntp.ContextMenuManager.ContextMenuItemId;
import org.chromium.chrome.browser.ntp.ContextMenuManager.Delegate;
import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
import org.chromium.chrome.browser.ntp.UiConfig;
@@ -17,8 +18,6 @@
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
-import java.util.HashSet;
-import java.util.Set;
/**
* Item that allows the user to perform an action on the NTP.
@@ -158,14 +157,8 @@ public String getUrl() {
}
@Override
- public Set<Integer> getSupportedMenuItems() {
- Set<Integer> supportedItems = new HashSet<>();
-
- if (isDismissable()) {
- supportedItems.add(ContextMenuManager.ID_REMOVE);
- }
-
- return supportedItems;
+ public boolean isItemSupported(@ContextMenuItemId int menuItemId) {
+ return menuItemId == ContextMenuManager.ID_REMOVE && isDismissable();
}
public void onBindViewHolder(ActionItem item) {

Powered by Google App Engine
This is Rietveld 408576698