Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4843)

Unified Diff: chrome/browser/banners/app_banner_manager.cc

Issue 2507163003: Prevent in-page navigations from stopping the app banner pipeline. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_manager.cc
diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc
index 9f98619aff3b33e811638b528b6e92750cd20d52..9f611fb4628a4ca9ae6d254336f1174718f47cf7 100644
--- a/chrome/browser/banners/app_banner_manager.cc
+++ b/chrome/browser/banners/app_banner_manager.cc
@@ -357,7 +357,7 @@ void AppBannerManager::SendBannerPromptRequest() {
}
void AppBannerManager::DidStartNavigation(content::NavigationHandle* handle) {
- if (!handle->IsInMainFrame())
+ if (!handle->IsInMainFrame() || handle->IsSamePage())
return;
load_finished_ = false;
@@ -372,7 +372,8 @@ void AppBannerManager::DidStartNavigation(content::NavigationHandle* handle) {
}
void AppBannerManager::DidFinishNavigation(content::NavigationHandle* handle) {
- if (handle->IsInMainFrame() && handle->HasCommitted()) {
+ if (handle->IsInMainFrame() && handle->HasCommitted() &&
+ !handle->IsSamePage()) {
last_transition_type_ = handle->GetPageTransition();
active_media_players_.clear();
if (is_active_)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698