Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2507063010: Moving string normalization out of HarfBuzz (Closed)

Created:
4 years, 1 month ago by eae
Modified:
4 years, 1 month ago
Reviewers:
drott, kojii
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moving string normalization out of HarfBuzz Move logic to normalize and upconvert strings out of HarfBuzzShaper into TextRun as it logically isn't a part of the text shaping process. This would also allow us to do it earlier in the processing pipeline for LayoutNG. Either prior to shaping or even at whitespace collapsing time. BUG=666758 R=drott@chromium.org,kojii@chromium.org Committed: https://crrev.com/a15729345604624f36e2d9b4902ed6a0ca2a2b3b Cr-Commit-Position: refs/heads/master@{#433685}

Patch Set 1 #

Patch Set 2 : Merge w/HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -87 lines) Patch
M third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 1 9 chunks +16 lines, -61 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp View 1 8 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextRun.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextRun.cpp View 2 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (19 generated)
eae
4 years, 1 month ago (2016-11-20 21:06:51 UTC) #11
kojii
lgtm
4 years, 1 month ago (2016-11-21 01:18:58 UTC) #12
drott
Nice, LGTM.
4 years, 1 month ago (2016-11-21 08:16:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507063010/20001
4 years, 1 month ago (2016-11-21 16:16:34 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/276901)
4 years, 1 month ago (2016-11-21 18:22:00 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507063010/20001
4 years, 1 month ago (2016-11-21 18:23:51 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/309594)
4 years, 1 month ago (2016-11-21 18:30:45 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507063010/40001
4 years, 1 month ago (2016-11-21 18:54:42 UTC) #24
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-11-21 23:18:25 UTC) #27
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 23:26:53 UTC) #29
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a15729345604624f36e2d9b4902ed6a0ca2a2b3b
Cr-Commit-Position: refs/heads/master@{#433685}

Powered by Google App Engine
This is Rietveld 408576698