Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h

Issue 2507063010: Moving string normalization out of HarfBuzz (Closed)
Patch Set: Merge w/HEAD Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h
diff --git a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h
index 416e02c28f0a19569daf97e619d0dc33898c4edf..fa69d9b506a0d4e5d39ae5f61b3a60bf5a44ebb1 100644
--- a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h
+++ b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h
@@ -131,7 +131,7 @@ class UnicodeRangeSet;
// sub-run, and the result is inserted into ShapeResult as well.
class PLATFORM_EXPORT HarfBuzzShaper final {
public:
- HarfBuzzShaper(const TextRun&);
+ HarfBuzzShaper(const UChar*, unsigned length, TextDirection);
PassRefPtr<ShapeResult> shapeResult(const Font*) const;
~HarfBuzzShaper() {}
@@ -166,9 +166,9 @@ class PLATFORM_EXPORT HarfBuzzShaper final {
unsigned numGlyphs,
hb_buffer_t*);
- const TextRun& m_textRun;
- std::unique_ptr<UChar[]> m_normalizedBuffer;
+ const UChar* m_normalizedBuffer;
unsigned m_normalizedBufferLength;
+ TextDirection m_textDirection;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698