Use aria range values for sliders

Use aria range values for sliders

 - adjust output for this role
 - omit descriptions that duplicate names

BUG=609549
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2507063007
Cr-Commit-Position: refs/heads/master@{#445498}
Committed: https://chromium.googlesource.com/chromium/src/+/cd764c0ecb3b077df566c3795bf757a3dede4659

[David Tseng, 2016-11-17 22:54:20]

Description was changed from

==========
Use aria range values for sliders - adjust output for this role - omit
descriptions that duplicate names

BUG=
==========

to

==========
Use aria range values for sliders - adjust output for this role - omit
descriptions that duplicate names

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-11-17 22:55:18]

Description was changed from

==========
Use aria range values for sliders - adjust output for this role - omit
descriptions that duplicate names

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Use aria range values for sliders

 - adjust output for this role
 - omit descriptions that duplicate names

BUG=609549
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-11-17 22:55:18]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-11-17 23:07:42]

I think we really need tests for this one, especially since there
are several permutations, we should make sure they all
generate good speech. For example, both input type=range and role=slider, and
input type=range with aria-valuenow or aria-valuetext - and then what happens if
there's a value but just min or just max, for example

Finally, this might be a good candidate for a custom braille
rule? How about something like:
"3 slider (1..5)".

https://codereview.chromium.org/2507063007/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
(right):

https://codereview.chromium.org/2507063007/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:529:
slider: {
You should expose range value attributes for these roles, it's potentially legal
for any of them:

      AX_ROLE_PROGRESS_INDICATOR
      AX_ROLE_METER
      AX_ROLE_SCROLL_BAR
      AX_ROLE_SLIDER
      AX_ROLE_SPIN_BUTTON

Alternatively, could you just trust that Blink won't expose these attributes
unless
they're relevant? I think there are quite a few rare attributes that might be
simpler to handle that way.

https://codereview.chromium.org/2507063007/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:531:
'$if($valueForRange, $valueForRange) ' +
I think $value is almost always better because it should contain aria-valuetext
if present, but the value otherwise.

[David Tseng, 2017-01-20 22:18:05]

https://codereview.chromium.org/2507063007/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
(right):

https://codereview.chromium.org/2507063007/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:529:
slider: {
On 2016/11/17 23:07:41, dmazzoni wrote:
> You should expose range value attributes for these roles, it's potentially
legal
> for any of them:
> 
>       AX_ROLE_PROGRESS_INDICATOR
>       AX_ROLE_METER
>       AX_ROLE_SCROLL_BAR
>       AX_ROLE_SLIDER
>       AX_ROLE_SPIN_BUTTON
> 
> Alternatively, could you just trust that Blink won't expose these attributes
> unless
> they're relevant? I think there are quite a few rare attributes that might be
> simpler to handle that way.

It would be, but it also prevents us from fine-tuning the output for each role
and clearly seeing how the output should look for a given role.

This is especially considering the confusion/disagreement about how these things
should bhave anyway (e.g. for meter:
https://github.com/w3c/aria/issues/451).

 I've added an abstractRange role so each of the above types can inherit from it
so it gives us good behavoir but also with the option to specialize if needed.

https://codereview.chromium.org/2507063007/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:531:
'$if($valueForRange, $valueForRange) ' +
On 2016/11/17 23:07:41, dmazzoni wrote:
> I think $value is almost always better because it should contain
aria-valuetext
> if present, but the value otherwise.


ok, done.

[David Tseng, 2017-01-20 22:19:11]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 22:19:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 22:21:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 22:21:30]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[David Tseng, 2017-01-20 22:35:35]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 22:35:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 00:26:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 00:26:56]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-01-23 19:53:56]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-01-23 19:53:57]

lgtm

[commit-bot: I haz the power, 2017-01-23 19:54:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 19:57:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 19:57:43]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[David Tseng, 2017-01-23 20:18:11]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2017-01-23 20:18:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2507063007/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-23 20:18:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 21:46:17]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485202691124600,
"parent_rev": "538d2655968dd8e6a8c3b8baec1b496dd4f74882", "commit_rev":
"cd764c0ecb3b077df566c3795bf757a3dede4659"}

[commit-bot: I haz the power, 2017-01-23 21:46:46]

Description was changed from

==========
Use aria range values for sliders

 - adjust output for this role
 - omit descriptions that duplicate names

BUG=609549
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Use aria range values for sliders

 - adjust output for this role
 - omit descriptions that duplicate names

BUG=609549
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2507063007
Cr-Commit-Position: refs/heads/master@{#445498}
Committed:
https://chromium.googlesource.com/chromium/src/+/cd764c0ecb3b077df566c3795bf7...
==========

[commit-bot: I haz the power, 2017-01-23 21:46:48]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cd764c0ecb3b077df566c3795bf7...